test(sdk): the unestablished-genesis-candidate test boots its own device (main's SDK board red since #1013) - #1017
Merged
Conversation
Main's SDK board was red on sdk::sofi_reads::tests::an_unestablished_genesis_candidate_is_not_read_as_unpublished since #1013: the test started the nodes but no device, and VerifierContext reads the committed network from this device's stored genesis, so it failed ("no genesis identity") wherever no earlier test had left an identity behind — and passed in targeted runs only because node_e2e_tests ran first. It now boots a Device (storage dir, nodes on Postgres, a created and published identity), as the admission tests do; the assertions are unchanged.
This was referenced Sep 26, 2026
cryptskii
added a commit
that referenced
this pull request
Sep 26, 2026
… board (#1019) The Rust tests (dsm_sdk) job of 97d6d55 (run 36226702605): 46 failed of 1020; 45 on the ERA refusal at an ERA transfer or burn, listed by name in §6.32; the one other, sofi_reads' unestablished-genesis-candidate test, is main's pre-existing red (#1013) fixed by #1017 and is named as such.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Main's SDK board is red on one test since #1013:
dsm_sdk::sdk::sofi_reads::tests::an_unestablished_genesis_candidate_is_not_read_as_unpublished(red on the runs of #1014 and #1015 alike, 1017/1 and 1014/1). This makes it establish its own device.Why it was red
The test started the storage nodes (
Fleet::start()) but no device.VerifierContext::newbuildsLiveSofiReadsovercommitted_network_id(), which reads the network from this device's stored genesis record — so in the serial board the test failed with "no genesis identity" wherever no earlier test had left an identity behind, and alone it panics earlier still ("DSM storage base dir not set"). It passed in my targeted runs only becausenode_e2e_testsran first in the same process and left a booted device.How
The test boots a
Device(test_support::one_device::Device::start): the storage dir, the nodes on Postgres, the set the SDK is pointed at, and a created and published identity — the same fixture the admission tests stand on. The assertions are unchanged.Verification (release, Postgres)
cargo test --locked --release -p dsm_sdk --lib -- sdk::sofi_reads::tests::an_unestablished_genesis_candidate_is_not_read_as_unpublished --exact --test-threads=1— the test ALONE, the condition under which it was red: before the change it fails (app_state.rs:84storage base dir not set; on CI "no genesis identity"); after the change → 1/0.make lint→ exit 0.