Stop selecting headings by tag in TestCafe page models - #39
Open
dougchestnut wants to merge 1 commit into
Open
dougchestnut wants to merge 1 commit into
dougchestnut wants to merge 1 commit into
Conversation
Dashboard, submission detail, and policy cards are identified by stable class or data-test attributes so pass-ui heading-level changes do not break verify() or turn verifyPolicyNotExists into an always-pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coordinates with eclipse-pass/pass-ui#1350 so the acceptance suite does not depend on heading tag names.
verify()uses.card-titleinstead ofh2.verifyTitleuses[data-test-submission-detail-title]instead ofh5.verifyPolicyExists/verifyPolicyNotExistsboth use[data-test-policy-title](noh3). That keeps the not-exists check from becoming an always-pass if the tag changes again.Needed by eclipse-pass/pass-ui#1350
Fixes eclipse-pass/main#1261