Skip to content

Stop selecting headings by tag in TestCafe page models #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dougchestnut wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop selecting headings by tag in TestCafe page models #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/page_model/Dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { currLocation, PASS_BASE_URL } from '../commonTest.js';

class Dashboard {
constructor() {
this.manageHeader = Selector('h2').withText(
this.manageHeader = Selector('.card-title').withText(
'Manage Publication Submissions'
);
this.submissionsLink = Selector('.nav-link.ember-view').withText(
Expand Down
4 changes: 3 additions & 1 deletion tests/page_model/SubmissionDetails.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ class SubmissionDetails {
constructor() {}

async verifyTitle(exptectedTitle) {
const submittedHeading = Selector('h5').withText(exptectedTitle);
const submittedHeading = Selector(
'[data-test-submission-detail-title]'
).withText(exptectedTitle);
await t.expect(submittedHeading.exists).ok();
}

Expand Down
12 changes: 6 additions & 6 deletions tests/page_model/SubmissionPolicies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@ class SubmissionPolicies {
}

async verifyPolicyExists(policyTitle) {
const jhuRepository = Selector('h3')
.withAttribute('data-test-policy-title')
.withText(policyTitle);
const jhuRepository = Selector('[data-test-policy-title]').withText(
policyTitle
);
await t.expect(jhuRepository.exists).ok();
}

async verifyPolicyNotExists(policyTitle) {
const jhuRepository = Selector('h3')
.withAttribute('data-test-policy-title')
.withText(policyTitle);
const jhuRepository = Selector('[data-test-policy-title]').withText(
policyTitle
);
await t.expect(jhuRepository.exists).notOk();
}

Expand Down