Conversation
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4124/ Sample changed pages: |
lcawl
force-pushed
the
changelog-note-registry-fixes-3
branch
from
September 16, 2026 20:22
20d5861 to
55689f8
Compare
Contributor
There was a problem hiding this comment.
Approved.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
2 tasks
lcawl
force-pushed
the
changelog-note-registry-fixes-3
branch
from
September 16, 2026 22:22
55689f8 to
d50f873
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the fourth and final phase of fixes for changelog note registry issues.
When it is merged, we can delete leftover
notes-{version}.jsonobjects from S3/CDN.{changelog}:cdn:pages no longer read them.Background
Relates to #4090, #4103
Per #4103 (comment), since the related issues touch the same areas of the code and have a significant, overlapping impact, this PR is part of a multi-PR phased approach.
Details
CdnChangelogFetcheronly loads:bundle/{product}/registry.jsoncloud-4.2.0.yaml,.amend-N,.amend-notes.yaml)src/Elastic.Markdownnever referencesnotes-. Notes indexes are only used bychangelog bundle.Do not delete
bundle/{product}/*.yamlorbundle/{product}/registry.json. Those are what the pages render.This cutover:
notes-{version}.jsonFetchNotesAsync404 fallback;changelog bundleonly GETsnotes-{product}-{version}.jsonA note upload (or
--skip-etag-checkon an existing note) is enough to trigger leftover version-only deletes. Manual S3 deletes of those objects are also safe for directive pages.Generative AI disclosure
Tool(s) and model(s) used: Cursor Grok 4.6