Skip to content

fix(cli): one guard for the two ways a run can say nothing about a model - #233

Merged
evkir merged 1 commit into
mainfrom
w2/honest-provenance
Aug 26, 2026
Merged

fix(cli): one guard for the two ways a run can say nothing about a model#233
evkir merged 1 commit into
mainfrom
w2/honest-provenance

Conversation

@evkir

@evkir evkir commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Codecov found a line the patch never executed, and it was a duplicate: an empty result list falls through the emptiness check and the no-proof check to the same answer, so the first guard could not be reached except through the second.

Removed, and the reachable path it stood for is now tested instead. An external suite whose checkout is absent scores 0/0 and still writes a card -- nothing ran, so the rollup has to answer that rather than divide by an empty run. Dropping the surviving guard raises a KeyError on that path, which is what the test catches.

What this changes

How it was measured

Checklist

  • ruff format --check cyberai/ tests/ and ruff check cyberai/ tests/ pass
  • pytest -W ignore::DeprecationWarning -m "not slow and not smoke" passes
  • New behaviour is covered by a test that fails without the change
  • I have read CLA.md and I hereby sign the CLA

Codecov found a line the patch never executed, and it was a duplicate:
an empty result list falls through the emptiness check and the
no-proof check to the same answer, so the first guard could not be
reached except through the second.

Removed, and the reachable path it stood for is now tested instead. An
external suite whose checkout is absent scores 0/0 and still writes a
card -- nothing ran, so the rollup has to answer that rather than
divide by an empty run. Dropping the surviving guard raises a KeyError
on that path, which is what the test catches.
@evkir
evkir merged commit b00be13 into main Aug 26, 2026
7 checks passed
@evkir
evkir deleted the w2/honest-provenance branch August 26, 2026 05:11
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants