fix(cli): one guard for the two ways a run can say nothing about a model - #233
Merged
Conversation
Codecov found a line the patch never executed, and it was a duplicate: an empty result list falls through the emptiness check and the no-proof check to the same answer, so the first guard could not be reached except through the second. Removed, and the reachable path it stood for is now tested instead. An external suite whose checkout is absent scores 0/0 and still writes a card -- nothing ran, so the rollup has to answer that rather than divide by an empty run. Dropping the surviving guard raises a KeyError on that path, which is what the test catches.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov found a line the patch never executed, and it was a duplicate: an empty result list falls through the emptiness check and the no-proof check to the same answer, so the first guard could not be reached except through the second.
Removed, and the reachable path it stood for is now tested instead. An external suite whose checkout is absent scores 0/0 and still writes a card -- nothing ran, so the rollup has to answer that rather than divide by an empty run. Dropping the surviving guard raises a KeyError on that path, which is what the test catches.
What this changes
How it was measured
Checklist
ruff format --check cyberai/ tests/andruff check cyberai/ tests/passpytest -W ignore::DeprecationWarning -m "not slow and not smoke"passes