Add missing node types dev dependency to firestore-incremental-capture - #2968
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds @types/node as a development dependency to the firestore-incremental-capture package. The reviewer correctly pointed out that the added @types/node version (^26.2.0) is invalid because Node.js 26 does not exist, and recommended updating it to ^22.0.0 to align with the package's engine specification of Node.js 22.
| "test": "echo \"Warning: tests are not implemented for this package\"" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^26.2.0" |
There was a problem hiding this comment.
The engine specified for this package is "node": ">=22". However, the @types/node version is set to ^26.2.0. Since @types/node major versions correspond to Node.js major versions (and Node.js 26 does not exist), this version is incorrect. Please update @types/node to ^22.0.0 to align with the Node.js 22 engine, and regenerate the npm-shrinkwrap.json file.
| "@types/node": "^26.2.0" | |
| "@types/node": "^22.0.0" |
2 participants
I know the package is totally empty still, but at least now it'll publish. The tsconfig.json was adding a package dependency that wasn't fulfilled.