Skip to content

Add missing node types dev dependency to firestore-incremental-capture #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inlined merged 1 commit into from
Aug 21, 2026
Merged

Add missing node types dev dependency to firestore-incremental-capture #2968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions kits/firestore-incremental-capture/npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions kits/firestore-incremental-capture/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,8 @@
"build": "tsc -b",
"clean": "tsc -b --clean",
"test": "echo \"Warning: tests are not implemented for this package\""
},
"devDependencies": {
"@types/node": "^26.2.0"

@gemini-code-assist gemini-code-assist Bot Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The engine specified for this package is "node": ">=22". However, the @types/node version is set to ^26.2.0. Since @types/node major versions correspond to Node.js major versions (and Node.js 26 does not exist), this version is incorrect. Please update @types/node to ^22.0.0 to align with the Node.js 22 engine, and regenerate the npm-shrinkwrap.json file.

Suggested change
"@types/node": "^26.2.0"
"@types/node": "^22.0.0"

}
}
Loading