Make Redis-backed assertions timing and order independent#104
Merged
flyingsquirrel0419 merged 1 commit intoJul 16, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe tests replace fixed delays with ChangesTest Reliability Updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
niksy
force-pushed
the
test/redis-test-semantics
branch
from
July 11, 2026 11:37
c95541b to
74bb773
Compare
14 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the Redis-backed test suites independent of timing and set-ordering assumptions. Uses
vi.waitForwhich resolves as soon as the assertion passes, so the suite should be both faster and deterministic.This also prepares these suites to run unchanged against a real Redis server (pending different PR).
Type of Change
Testing
npm test)npm run lint)npm run build:all)Checklist
CHANGELOG.mdand package versions when the PR changes release scopeas any,@ts-ignore,@ts-expect-error)Summary by CodeRabbit
Summary by CodeRabbit