Dynamic PostgreSQL effect - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, functions like
query_,insertetc were just concrete functions using theWithConnectioneffect, since there was only one possible way to interpret them.Now we have a dynamic
PostgreSQLeffect that allows multiple interpretations. For now there's just the obvious one that calls out to the corresponding functions frompostgresql-simple(basically identical to the previous situation). However this will enable us to define alternative interpreters, e.g. one that uses the instrumented versions of the same functions fromhs-opentelemetry-instrumentation-postgresql-simple(see #6).This changes the type signatures of almost all the functions, so this is a breaking change.