Support OpenTelemetry instrumentation - #16
Merged
Merged
Conversation
fpringle
force-pushed
the
fpringle/support-opentelemetry
branch
from
September 22, 2026 09:03
268c8a4 to
92e0b78
Compare
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #15, we can now very easily add support for OpenTelemetry instrumentation in a "first-class" way.
Namely, we simply provide an alternative
PostgreSQLinterpreterrunPostgreSQLOTthat uses the functions from hs-opentelemetry-instrumentation-postgresql-simple instead ofpostgresql-simple. This means the user can choose which interpreter they want to use (with or without OpenTelemetry), even at runtime e.g. according to a configuration file.This PR also removed
tested-withsupport for GHC8.*, since it was causing build failures in dependencies and I can't be bothered to figure out why. If anyone desperately wants GHC8.*support and wants to do the work for it they can open a PR.