feat(updater): remove duplicate Updates UI; now lives in slopsmith - #19
Open
mogul wants to merge 1 commit into
Open
feat(updater): remove duplicate Updates UI; now lives in slopsmith#19mogul wants to merge 1 commit into
mogul wants to merge 1 commit into
Conversation
The Velopack auto-update controls have moved into slopsmith's own Settings page as a top-level "App Updates" block (slopsmith #372). The audio_engine plugin's settings panel — where they were initially placed — would otherwise render a second copy of the same UI once the desktop bundle picks up the new slopsmith static. Removed: - src/renderer/settings.html: the #ae-updates-section card. - src/renderer/screen.js: setupUpdateChannelControls() and its call site in setupEvents(); the top-level restart-banner IIFE (now wired by slopsmith's initAppUpdateBanner()). Cherry-picked from slopsmith-desktop#214, manually resolved against main.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to slopsmith #372 (merged 145a20a0b), which moved the Velopack auto-update controls into slopsmith's own Settings page as a top-level App Updates block.
The audio_engine plugin's settings panel — where the Updates UI was initially placed — would otherwise render a second copy of the same UI once the desktop bundle picks up the new slopsmith static.
Removed:
src/renderer/settings.html: the#ae-updates-sectioncard (channel dropdown, check-for-updates button, status line, Linux fallback note).src/renderer/screen.js:setupUpdateChannelControls()and its call site insetupEvents(); the top-levelrenderUpdateBannerIIFE (now wired by slopsmith'sinitAppUpdateBanner()).Kept (unchanged):
src/main/update-manager.ts,preload.ts,ipc-channels.ts— the Velopack IPC backend. slopsmith'sapp.jsconsumes it viawindow.slopsmithDesktop.update.Conflict resolution
Cherry-pick from
a186e88conflicted on both files because the surrounding code onmainhad diverged significantly. Resolved by manually applying the PR's deletions (removing the same UI blocks) against the currentmaincontent.