tonic-xds: allow deprecated fetch_update until MSRV >= 1.95 - #2904
Merged
YutaoMa merged 1 commit intoOct 1, 2026
Merged
Conversation
Rust 1.99 deprecates `fetch_update` in favor of `try_update`, which is only stable since 1.95, above our 1.88 MSRV.
YutaoMa
marked this pull request as ready for review
October 1, 2026 21:27
ejona86
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CI blocked because of Rust 1.99 clippy now warns on use of deprecated
fetch_upatein favor oftry_update. Howeverfetch_upateis only stable since 1.95 which is above the current msrv.Solution
#[allow(deprecated)]with TODO reminders to delete later when msrv bumps.