fix: honor report_to when constructing the internal ST trainer - #643
Closed
tonycoder-hub wants to merge 2 commits into
Closed
fix: honor report_to when constructing the internal ST trainer#643tonycoder-hub wants to merge 2 commits into
tonycoder-hub wants to merge 2 commits into
Conversation
The reporting callbacks of the internal Sentence Transformers trainer were created from the default 'all' setting rather than from the SetFit TrainingArguments, so integrations that the user did not request were still initialized and executed. Co-authored-by: Tony Coder <407243179@qq.com>
Co-authored-by: Tony Coder <407243179@qq.com>
This was referenced Aug 17, 2026
Author
|
Closing as stale — opened on or before 2026-08-17 and still unmerged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BCSentenceTransformersTrainerbuiltSentenceTransformerTrainingArgumentswith onlyoutput_dir, soreport_todefaulted to"all".transformers.Trainer.__init__registered every installed integration (including DagsHub) before_apply_training_argumentscopied the user'sreport_to.On Windows,
DagsHubCallback.setupthen splitsMLFLOW_TRACKING_URIonos.sepand crashes even when the user asked forreport_to="mlflow"(or"none").Pass
report_toat construction time so callbacks match the user's setting.Closes #621
Test plan
pytest tests/test_trainer.py tests/test_training_args.py tests/test_model_card.py -q→ 50 passed, 2 skippedtest_trainer_report_tofails on current main (report_to="none"still registers a dummy integration) and passes after the change