fix(ci): repair must-gates and the Justfile parse collision - #66
Merged
Conversation
Two independent defects made the quality-gates workflow structurally unable to pass on any PR or push: 1. Justfile parse death: 'import? "contractile.just"' merges recipe namespaces, and contractile.just:60 already defines trust-verify (license/secrets/container aggregate). The root Justfile's trust-verify redefinition killed every 'just' invocation at parse time, so 'just test-all' never ran a single test in CI. Renamed the root recipe to trust-manifest-verify and repointed ci-gate + README. 2. md->adoc rot: all six components renamed SECURITY.md to SECURITY.adoc, but run-must-gates.sh still required SECURITY.md (x3) and generate-manifest.sh still hashed it, so the must-gates job could never go green. Verified locally end-to-end: run-must-gates.sh prints 'all must gates passed', verify-manifest.sh exits 0, just --evaluate exits 0, and 'just test-all' passes with zero failures underneath. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Every manifest was frozen at generated_at=2026-02-28 with all 42 entries failing (SECURITY.md renamed to .adoc plus stale checksums). Regenerated with the repo's own scripts/trust/generate-manifest.sh after the .adoc fix in the previous commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 28 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 1, 2026
Merged
hyperpolymath
added a commit
that referenced
this pull request
Sep 1, 2026
…igned (#67) ## What `Aggregate_Profile` computed means only. `Std_Dev_ISA`, `Median_ISA`, `Category_Std_Devs`, `Category_Medians` and `Evaluated_At` were returned **uninitialized**, and `vexometer-reports.adb` prints those fields into CSV/HTML/LaTeX/text reports — so every generated report carried undefined memory as real statistics. ## Why now The E2E assertion `Std_Dev_ISA >= 0.0` failed nondeterministically on PR #63 — the first CI test runs in this repo's history, enabled by the #66 gate repair. Identical sources passed on #64/#65/#66 and failed on #63: classic uninitialized-read behaviour (GNAT warned `"Profile" may be referenced before it has a value` at `vexometer-core.adb:100` all along; that warning is now gone). ## How - Standard deviations use the **two-pass form** — summed squared deviations cannot go negative, unlike `E[x²] − E[x]²`. - Medians sort a copy (`Ada.Containers.Generic_Array_Sort`), correct for odd and even N. - Numeric components of `Model_Profile` now default to zero, so the `N = 0` path returns defined values. - `Evaluated_At` is stamped with `Ada.Calendar.Clock`. ## Verification `just test` in `vexometer/`: **1282/1282 assertions pass**, three consecutive runs, exit 0 each (previously flaky). No manifest-tracked files touched. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
hyperpolymath
added a commit
that referenced
this pull request
Sep 1, 2026
## Summary Closes out the 2026-09-01 decode-and-repair pass with the situation report and the last mechanical documentation fixes. Everything narrative lives in the sitrep itself: **docs/sitrep-2026-09-01.adoc**. - **Sitrep** — repo/branch state and the lossless rebase resolution, the quality-gate outage (#66) and the two defects the repaired gates caught immediately (#67 uninitialized profile statistics, #64 unparseable workflow-linter), the verified Anthropic-paper provenance and the ISA/safety-alignment boundary, a documentation honesty audit, and a debt register (D1–D7) with done-conditions. - **STATE.a2ml** — `last-updated` refreshed; the 25%-vs-70% divergence and the assertion-execution counting convention annotated (true refresh = D3). - **SATELLITES.adoc** — dead `.scm` links repointed to `.machine_readable/6a2/*.a2ml`; retired-format NOTE on the ECOSYSTEM.scm template section. - **vexometer-satellites/README.adoc** — false claim to hold the protocol specs removed; dead `docs/*-format.adoc` links repointed to the real specs; trust manifest regenerated in the same commit per the manifest contract. - **TEST-NEEDS.adoc** — the 1282 figure annotated as assertion executions (420 loop-amplified), ~55 static sites. ## Verification - `bash scripts/run-must-gates.sh` → exit 0, "all must gates passed" (with the regenerated vexometer-satellites manifest). - All links added here resolve on this branch; no `link:*.scm` remains in SATELLITES.adoc. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
quality-gatesworkflow is structurally unable to pass — on any PR and on any push to main. Both jobs red-team themselves:test-allnever ran a test.import? "contractile.just"merges recipe namespaces, andcontractile.just:60already definestrust-verify(the license/secrets/container aggregate). The root Justfile redefined it at line 76, so everyjustinvocation died at parse time withRecipe 'trust-verify' first defined on line 60 is redefined on line 76. CI has only ever seen the parse error, never a test.must-gateswas unsatisfiable. All six components renamedSECURITY.md→SECURITY.adoc, butrun-must-gates.shstill requiredSECURITY.md(×3) andgenerate-manifest.shstill hashed it. On top of that, all six trust manifests were frozen atgenerated_at=2026-02-28with all 42 entries failing.This is why #63, #64, and #65 are all red: same two gates, not their own content.
What
trust-verify→trust-manifest-verify(contractile's aggregate keeps the old name); repointci-gateand the README quick-start.SECURITY.md→SECURITY.adocinscripts/run-must-gates.sh(×3) andscripts/trust/generate-manifest.sh(×1)..trust/trust-manifest.sha256with the repo's own generator (second commit, mechanical).Verification (local, end-to-end)
bash scripts/run-must-gates.sh→ printsall must gates passed, exit 0bash scripts/trust/verify-manifest.sh→ all six verified, exit 0just --evaluate→ exit 0;just --summaryshows bothtrust-manifest-verifyand contractile'strust-verifyjust test-all→ exit 0 (Ada + Rust + lazy-eliminator's 16 property tests, no failures hiding under the parse death)Note for future PRs
The manifests pin content hashes of each component's README/ROADMAP/SECURITY/Mustfile/Trustfile/RSR_OUTLINE/CITATIONS. Any PR touching one of those files must regenerate manifests in the same PR (
just trust-generate) ormust-gatesreds on its merge ref. #63 needs exactly that after this lands.🤖 Generated with Claude Code