fix(cursor): expose Grok 4.6 xhigh thinking - #1578
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
Ingwannu
left a comment
There was a problem hiding this comment.
The regular Grok 4.6 direction is supported on exact head f2ee5d1973192b7daa20942c7af333baf01004b0: the two focused suites pass 21/21, typecheck/privacy/diff check are green, and the PR reports authenticated HTTP 200 probes for regular cursor/grok-4.6 at low/high/xhigh.
I am requesting changes because the code also adds xhigh to grok-4.6-fast, but the evidence and new regression cover only the regular model. That materially changes the parameterized Fast request from clamping xhigh -> high to sending { effort: \"xhigh\", fast: \"true\" }. PR #1547 deliberately separated observed regular wire IDs from inherited Fast behavior; this PR should preserve that evidence boundary.
Please do one of the following:
- limit the tier change to
grok-4.6and leavegrok-4.6-fastat low/medium/high; or - provide an authenticated Fast xhigh success capture and add a regression for
selectionFor(\"cursor/grok-4.6-fast\", \"xhigh\")plus its advertised picker ladder.
After that, rebase onto the latest dev, complete the readiness checklist, and obtain exact-head CI. The regular-model change remains small and valuable.
|
Closing: this only duplicated the already-open Grok 4.6 integration work in #1547. The local setup will track that PR branch instead. |
Summary
xhightier advertised by the Cursor Agent CLI.cursor/grok-4.6[effort=xhigh]to Cursor wire modelcursor-grok-4.6-xhigh.This intentionally complements, rather than duplicates, #1547, which verifies the existing low/medium/high Grok 4.6 support.
Verification
bun test tests/cursor-effort-suffix.test.ts tests/cursor-discovery.test.ts— 21 passedbun run typecheck— passedcursor/grok-4.6returned HTTP 200 forlow,high, andxhigh.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.