docs(devlog): release-readiness note for the cursor-call integration - #1996
Merged
Conversation
The five gates ran against the MERGED dev SHA 4f72d6f, not the pre-merge tip — a merge commit is a tree nobody has tested until it is tested. All green in a lidge worktree pinned to that SHA, with HEAD re-asserted before each gate. Recommends 2.25.0, a minor rather than a patch, because the externally observable behaviour of a FAILED turn changed: a turn that came back completed with a vanished tool call now reports failed, an unrequested CANCEL is now a typed failure, and a truncated compaction turn no longer installs half-written replacement history. Correct behaviour, but new behaviour for anything keying on "the proxy said completed". The maintainer decides; the note recommends. Says two things plainly rather than burying them. The merges were owner-authorized admin merges with CI waived — that is owner authority over one's own repository, not compliance with MAINTAINERS.md:48-49, and lidge is Linux-only while CI spans three platforms. And publishing is not one command away: scripts/release.ts waits for a successful Cross-platform CI run AND a Service lifecycle run at the exact release SHA, so a green gate table alone does not mean bun run release will work. Carries the five open follow-ups, led by the one the campaign's own docs previously overstated: the Cursor tool-result image encoder is correct and does not reach production, because every Cursor model is in noVisionModels and the vision sidecar strips images before the adapter runs.
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release-readiness note documents the recommended ChangesCursor-call release readiness
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release-readiness note for the cursor-call integration campaign (#1993 / #1994 / #1995, merged as
4f72d6f75).Records the five release gates run against the merged dev SHA rather than the pre-merge tip — a merge commit is a tree nobody has tested until it is tested — and recommends cutting
2.25.0as a minor, because the externally observable behaviour of a failed turn changed.Says two things plainly instead of burying them: the merges were owner-authorized admin merges with CI waived, which is owner authority and not compliance with
MAINTAINERS.md:48-49; and publishing is not one command away, sincescripts/release.tswaits for Cross-platform CI and Service lifecycle at the exact release SHA.Carries the five open follow-ups, led by the one the campaign's own docs previously overstated: the Cursor tool-result image encoder is correct and does not reach production, because every Cursor model is in
noVisionModelsand the vision sidecar strips images before the adapter runs.Verification
Docs-only change — no source, tests, or build inputs touched.
The gates this note records ran on
ssh lidgeat4f72d6f7555013ab231de78233d2aa95bd1e439cin a worktree pinned to that SHA, with HEAD re-asserted before each:Checklist
privacy:scangreen at the recorded SHA.)Summary by CodeRabbit