ci: modernize the pipeline and bump the Go baseline - #2
Merged
Conversation
Port the proxycheck CI template into this repo: - go.yml moves to actions/checkout@v4 and actions/setup-go@v5, a 1.25/1.26 Go matrix across the existing three OSes, and codecov/codecov-action@v4 instead of the deprecated piped-curl uploader. The old matrix pinned 1.18/1.19, whose toolchains are no longer downloadable: the macOS job had been failing in setup with 403 on go1.18.10.darwin-arm64.tar.gz. - golangci-lint.yml is new, a copy of proxycheck's, pinning golangci-lint v2.12.2 via golangci/golangci-lint-action@v7. - go.mod declares go 1.25. Lint findings from the new workflow, all behaviour-preserving: io/ioutil replaced by io (SA1019, in both the library and its tests), the Cookies copy loop replaced by a variadic append (S1011), and the deferred res.Body.Close error explicitly discarded (errcheck). No API or behaviour change.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports the
proxycheckCI template into this repo, so the wholememclutterGo fleet shares one pipeline shape.
go.yml—actions/checkout@v4,actions/setup-go@v5, matrix1.25/1.26across the existingubuntu/windows/macOSspread, andcodecov/codecov-action@v4replacingbash <(curl -s https://codecov.io/bash).golangci-lint.yml— new, a copy of proxycheck's, pinning golangci-lintv2.12.2viagolangci/golangci-lint-action@v7.go.mod—go 1.18→go 1.25.README.md— a golangci-lint badge alongside the CI one.Why
The old matrix pinned Go
1.18/1.19, and those toolchains are no longerdownloadable for current runners.
mainhas been red since June for exactlythat reason — not a flake, and not a code failure:
macOS-latestis arm64 now. So the action bump and thego.modbump have toship together; neither fixes the build alone.
Lint fallout
The new lint workflow reported 4 issues, all fixed here, all
behaviour-preserving:
SA1019io/ioutildeprecated (library + tests)io.ReadAllS1011Cookies()copy loopappend(r.cookies, cookies...)errcheckondefer res.Body.Close()defer func() { _ = res.Body.Close() }()No API change, no behaviour change, and no test was modified beyond the
ioutil→ioswap — the existing suite is what proves the version bump issafe.
Verification
Local, under the bumped
go.mod(Go 1.25 fetched viaGOTOOLCHAIN=auto):go build ./...,go test -count=1 ./... -race(40 tests),golangci-lint runclean,
gofmt -l .empty. The real gate is this PR's 6 test jobs pluslint—in particular that
macOS-latestnow reaches the test step at all.Note
The Codecov upload uses
fail_ci_if_error: false, so ifCODECOV_TOKENis notset in this repo the step degrades to a no-op rather than reddening the build.
🤖 Generated with Claude Code