TOOLS-4263 Add a Go test that we preserve indexes when restoring with a non-admin user on a per-data basis

[autarch]

Adds TestRestoreWithDBUserPreservesIndexes in mongorestore/dumprestore_auth_test.go, which
closes the last coverage gap in restorewithauth.js so that JS test can be deleted.

JS -> Go mapping:

• test/legacy42/jstests/tool/restorewithauth.js ->
  TestDumpRestoreEnforcesAuthRoles (mongorestore/dumprestore_auth_test.go, pre-existing) + TestRestoreWithDBUserPreservesIndexes (mongorestore/dumprestore_auth_test.go, new in this PR)

The JS test covered two things against an auth-enabled server. The first — that dump and restore fail without adequate roles and succeed with them — is already covered by TestDumpRestoreEnforcesAuthRoles. The second was not covered: that a user holding only readWrite on a single database can restore that database and its secondary indexes come back. TestRestoreWithDBUserPreservesIndexes creates two collections (one with a secondary index on x), dumps and restores them as a per-database readWrite user, and asserts both the documents and the index count are restored.

[autarch]

• TOOLS-4263 Convert mongorestore invalid-input tests to Go #1046 : 2 dependent PRs (#1048 , #1060 )
• TOOLS-4263 Delete JS tests fully covered by existing Go tests #1041
• TOOLS-4263 Add a Go test that we preserve indexes when restoring with a non-admin user on a per-data basis #1047 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[mmcclimon]

Sure, ok with me. I think the test the JS test does isn't exactly covered with the existing Go tests, though, because it does a dump on an unauth cluster and first tries to restore it with an auth cluster. Maybe we don't need to test that, though; I'll leave it up to you.

[mmcclimon]

Suggested change

	for i := 0; i < 4; i++ {
	for i := range 4 {

(nit)

[autarch]

I updated this to add something that tests that restoring without auth fails when auth is enabled. That seems like the most important thing that was missing.

[autarch]

Merge activity

• Aug 6, 7:53 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Aug 6, 7:54 PM UTC: Graphite rebased this pull request as part of a merge.
• Aug 6, 7:54 PM UTC: @autarch merged this pull request with Graphite.