TOOLS-4263 Convert mongorestore replica-set oplog-replay tests to Go by autarch · Pull Request #1049 · mongodb/mongo-tools

autarch · 2026-07-23T13:44:15Z

Adds TestOplogReplayFromLocalOplogRS in mongorestore/oplog_replset_test.go, which ports two JS tests into a single Go test. It records a checkpoint timestamp, performs more writes, dumps local.oplog.rs with a {ts: {$gt: <checkpoint>}} query, and replays that dump with --oplogReplay --oplogFile, asserting only the ops after the checkpoint are applied. This test requires a replica set, so it is gated on testtype.ReplSetTestType (TOOLS_TESTING_REPLSET) rather than the plain integration test type; that is why these two JS tests were deliberately left out of the earlier oplog edge-case conversion.

JS -> Go mapping (both map to TestOplogReplayFromLocalOplogRS in mongorestore/oplog_replset_test.go):

test/qa-tests/jstests/restore/oplog_replay_local_rs.js -> TestOplogReplayFromLocalOplogRS (mongorestore/oplog_replset_test.go) - the --oplogReplay --oplogFile replay half: a dumped local/oplog.rs.bson is replayed against the live replica set and only the expected ops take effect.
test/legacy42/jstests/tool/dumprestore7.js -> TestOplogReplayFromLocalOplogRS (mongorestore/oplog_replset_test.go) - the mongodump half: dumping local.oplog.rs with a {ts: {$gt: ...}} timestamp query captures exactly the ops after the checkpoint.

autarch · 2026-07-23T13:44:31Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

mmcclimon

Alright, though I'd probably move these to the dumprestore package and write them to match that style.

mmcclimon · 2026-08-10T13:48:46Z

+		`{"ts":{"$gt":{"$timestamp":{"t":%d,"i":%d}}},"ns":%q,"op":"i"}`,
+		checkpoint.T, checkpoint.I, ns,
+	)
+	require.NoError(t, runDump(t, baseToolOpts(t), dumpDir, func(md *mongodump.MongoDump) {


Should these really go in the mongorestore directory, since they're actually running dump + restore?

mmcclimon · 2026-08-10T13:55:10Z

+	checkpoint := latestOplogTimestamp(t, client)
+
+	// Second batch: these ops follow the checkpoint and must be replayed.
+	const secondBatch = 7


(nit) This const is pretty weird, as is the choice of the number 7?

Claude picked this semi-randomly, but it should differ from the first batch size, so we can be sure that it picks the right "side" of the oplog (with 7 entries after the timestamp rather than 5 before).

mmcclimon · 2026-08-10T13:55:46Z

+		"only the ops after the checkpoint are replayed",
+	)
+
+	batch1Count, err := coll.CountDocuments(ctx, bson.M{"batch": 1})


We usually use bson.D for all of these.

autarch · 2026-08-12T18:36:52Z

Merge activity

Aug 12, 6:36 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Aug 12, 6:42 PM UTC: Graphite rebased this pull request as part of a merge.
Aug 12, 6:42 PM UTC: @autarch merged this pull request with Graphite.

This adds a new `TestOplogReplayFromLocalOplogRS` test in `mongorestore/oplog_replset_test.go`. This ports two JS tests into one Go test. It dumps `local.oplog.rs` with a `$gt` timestamp query and replays the dump via `--oplogReplay --oplogFile ...`, verifying only the ops after the checkpoint are applied. JS -> Go mapping: - test/qa-tests/jstests/restore/oplog_replay_local_rs.js -> the --oplogReplay --oplogFile replay of a dumped local/oplog.rs.bson - test/legacy42/jstests/tool/dumprestore7.js -> the mongodump of local.oplog.rs with a {ts:{$gt:...}} timestamp query

autarch mentioned this pull request Jul 23, 2026

TOOLS-4263 Convert mongorestore oplog-replay edge-case tests to Go #1048

Closed

autarch force-pushed the 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go branch from 6e72aea to 60200d1 Compare July 23, 2026 18:19

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from f43b301 to e8077fc Compare July 23, 2026 18:19

autarch force-pushed the 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go branch from 60200d1 to 04c98db Compare July 24, 2026 16:40

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from e8077fc to c060980 Compare July 24, 2026 16:40

autarch force-pushed the 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go branch from 04c98db to 8fc1df8 Compare July 27, 2026 21:16

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from c060980 to 6b97a36 Compare July 27, 2026 21:17

autarch mentioned this pull request Jul 27, 2026

TOOLS-4263 Convert mongorestore oplog-replay edge-case tests to Go #1060

Merged

autarch force-pushed the 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go branch from 8fc1df8 to cb21dec Compare August 5, 2026 21:43

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from 6b97a36 to 6108e99 Compare August 5, 2026 21:43

autarch mentioned this pull request Aug 5, 2026

TOOLS-4263 Convert mongorestore collection-options and metadata tests to Go #1073

Open

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from 6108e99 to d36edee Compare August 5, 2026 21:47

autarch force-pushed the 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go branch from cb21dec to 20dc955 Compare August 5, 2026 21:48

autarch mentioned this pull request Aug 6, 2026

TOOLS-4263 Convert mongorestore index round-trip tests to Go #1074

Open

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from d36edee to b2f3635 Compare August 6, 2026 21:25

autarch force-pushed the 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go branch from 20dc955 to cdfbc96 Compare August 6, 2026 21:25

This was referenced Aug 6, 2026

TOOLS-4263 Convert mongorestore bulk sizing tests to Go #1091

Draft

TOOLS-4263 Convert mongorestore namespace mapping tests to Go #1093

Draft

autarch requested a review from mmcclimon August 7, 2026 16:35

autarch marked this pull request as ready for review August 7, 2026 16:36

autarch requested a review from a team as a code owner August 7, 2026 16:36

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from b2f3635 to dee6aeb Compare August 7, 2026 18:41

autarch force-pushed the 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go branch from cdfbc96 to 2ab1f91 Compare August 7, 2026 18:42

This was referenced Aug 7, 2026

TOOLS-4263 Convert mongorestore drop, path and stdin tests to Go #1096

Draft

TOOLS-4263 Convert mongorestore users and roles temp collection tests to Go #1097

Draft

TOOLS-4263 Convert mongodump flag validation tests to Go #1098

Draft

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from dee6aeb to 51f2499 Compare August 7, 2026 18:57

mmcclimon approved these changes Aug 10, 2026

View reviewed changes

autarch force-pushed the 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go branch from 0343320 to aa0f959 Compare August 10, 2026 20:44

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from 51f2499 to 5bc5a26 Compare August 10, 2026 20:44

autarch mentioned this pull request Aug 10, 2026

TOOLS-4263 Convert mongodump query and data behavior tests to Go #1102

Draft

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from 5bc5a26 to c7741dd Compare August 10, 2026 21:22

autarch force-pushed the 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go branch from aa0f959 to 4d1d9e4 Compare August 10, 2026 21:22

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from c7741dd to ec6cd0a Compare August 11, 2026 17:11

autarch force-pushed the 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go branch from 4d1d9e4 to 5b3c649 Compare August 11, 2026 17:11

autarch mentioned this pull request Aug 11, 2026

TOOLS-4263 Convert mongodump oplog consistency tests to Go #1104

Draft

autarch changed the base branch from 07-17-tools-4263_convert_mongorestore_oplog-replay_edge-case_tests_to_go to graphite-base/1049 August 12, 2026 18:39

autarch changed the base branch from graphite-base/1049 to master August 12, 2026 18:40

autarch force-pushed the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch from ec6cd0a to bf3464c Compare August 12, 2026 18:41

autarch merged commit a069aa5 into master Aug 12, 2026
6 of 7 checks passed

autarch deleted the 07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go branch August 12, 2026 18:42

Navigation Menu

Uh oh!

TOOLS-4263 Convert mongorestore replica-set oplog-replay tests to Go - #1049

TOOLS-4263 Convert mongorestore replica-set oplog-replay tests to Go#1049
autarch merged 1 commit into
masterfrom
07-23-tools-4263_convert_mongorestore_replica-set_oplog-replay_tests_to_go

autarch commented Jul 23, 2026 •

edited

Loading

Uh oh!

autarch commented Jul 23, 2026 •

edited

Loading

Uh oh!

mmcclimon left a comment

Uh oh!

mmcclimon Aug 10, 2026

Uh oh!

autarch Aug 10, 2026

Uh oh!

mmcclimon Aug 10, 2026

Uh oh!

autarch Aug 10, 2026

Uh oh!

mmcclimon Aug 10, 2026

Uh oh!

autarch Aug 10, 2026

Uh oh!

autarch commented Aug 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

autarch commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

autarch commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmcclimon left a comment

Choose a reason for hiding this comment

Uh oh!

mmcclimon Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

autarch Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

mmcclimon Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

autarch Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

mmcclimon Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

autarch Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

autarch commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

autarch commented Jul 23, 2026 •

edited

Loading

autarch commented Jul 23, 2026 •

edited

Loading

autarch commented Aug 12, 2026 •

edited

Loading