TOOLS-4278 Convert mongoimport TestImportDocuments to testify - #1076
Draft
autarch wants to merge 1 commit into
Draft
Conversation
At 827 lines this is the largest function in the file, and the only one so far where the GoConvey re-execution semantics mattered. Every leaf shared one collection, and GoConvey re-ran the outer block per leaf, so the Reset cleared that collection 51 times. Subtests do not work that way: a shared parent would run setup once and let each subtest inherit whatever its siblings left behind. The teardown is now a cleanImportCollection helper that every subtest calls, registering its own t.Cleanup, so the 51 leaf executions still get 51 clears. The cleanup deletes with context.Background() rather than t.Context(). t.Context() is cancelled just before Cleanup functions run, so the delete failed with "context canceled" until this was changed. Isolation was checked empirically rather than assumed: three consecutive runs, -count=5, three shuffled runs, all 52 subtests run individually, and zero residual documents afterwards. The three t.Fatalf checks in the old Reset body become require.NoError in the helper, which is the only reason the assertion count moves at all: 120 before, 123 after. No behavior change.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At 827 lines this is the largest function in the file, and the only one
so far where the GoConvey re-execution semantics mattered.
Every leaf shared one collection, and GoConvey re-ran the outer block per
leaf, so the Reset cleared that collection 51 times. Subtests do not work
that way: a shared parent would run setup once and let each subtest
inherit whatever its siblings left behind. The teardown is now a
cleanImportCollection helper that every subtest calls, registering its own
t.Cleanup, so the 51 leaf executions still get 51 clears.
The cleanup deletes with context.Background() rather than t.Context().
t.Context() is cancelled just before Cleanup functions run, so the delete
failed with "context canceled" until this was changed.
Isolation was checked empirically rather than assumed: three consecutive
runs, -count=5, three shuffled runs, all 52 subtests run individually,
and zero residual documents afterwards.
The three t.Fatalf checks in the old Reset body become require.NoError in
the helper, which is the only reason the assertion count moves at all:
120 before, 123 after. No behavior change.