TOOLS-4278 Clean up after the testify migration - #1090
Draft
autarch wants to merge 1 commit into
Draft
Conversation
Three leftovers that only show up once the whole conversion is in place. Two commits in this stack each extracted a subtest fixture helper for mongodump_test.go, and the bodies turned out identical. They collapse into one setUpMongoDumpSubtest, now serving all fifteen call sites. mongorestore_archive_test.go still carried a banner saying tests below that line use testify rather than convey. Everything above it does now too, and there is no convey left to distinguish from. common/text/units_test.go held a commented-out copy of its old GoConvey version, left behind by a conversion that predates this ticket. With the dependency gone it was the last GoConvey source text outside vendor, so it would have turned up in the first grep anyone ran to confirm the removal.
This was referenced Aug 6, 2026
Collaborator
Author
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three leftovers that only show up once the whole conversion is in place.
Two commits in this stack each extracted a subtest fixture helper for
mongodump_test.go, and the bodies turned out identical. They collapse
into one setUpMongoDumpSubtest, now serving all fifteen call sites.
mongorestore_archive_test.go still carried a banner saying tests below
that line use testify rather than convey. Everything above it does now
too, and there is no convey left to distinguish from.
common/text/units_test.go held a commented-out copy of its old GoConvey
version, left behind by a conversion that predates this ticket. With the
dependency gone it was the last GoConvey source text outside vendor, so
it would have turned up in the first grep anyone ran to confirm the
removal.