refactor(js/net)!: drop transport from ReloadProps - #2665
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 152e11119c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kixelated
force-pushed
the
claude/reload-props-omit-transport
branch
from
August 5, 2026 22:17
152e111 to
5af2ab5
Compare
Reload.#connect has never forwarded ConnectProps.transport, so a caller supplying a session silently got a fresh dial instead. The option cannot work here by construction: a supplied session is good for exactly one connection, so the reconnect loop has nothing to reuse once it drops. Narrow ReloadProps to exclude signal and transport, with optional never members so both literals and preassembled config objects fail to type-check. Bump @moq/net to 0.4.0 for the breaking API change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
kixelated
force-pushed
the
claude/reload-props-omit-transport
branch
from
August 6, 2026 01:16
5af2ab5 to
79cdcee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reload.#connecthas never forwardedConnectProps.transporttoconnect(), so a caller who supplied a pre-existingWebTransportsilently got a fresh dial instead.connect()remains the entry point for handing over a session.ReloadPropsto omitsignalandtransport, then explicitly forbid both with optionalnevermembers. This rejects both inline object literals and preassembled config objects instead of silently ignoring either field.@moq/netfrom 0.3.0 to 0.4.0 for the breaking published API change.Public API changes
ReloadPropsno longer acceptstransport.signalexclusion now also rejects preassembled option objects. CurrentReloadowns the abort signal for each connection attempt.ConnectProps.transport,ConnectProps.signal, andconnect()are unchanged.devper Branch Targeting.Test plan
@moq/netsource suite: 354 pass, 0 fail.Checkpassed on79cdceeafin 3m42s.Cross-package sync
js/net/package.jsonandbun.lockto 0.4.0.doc/lib/js/@moq/net.mdnever documentedtransportonReload, so no docs change is needed.Interaction with #2655
#2655 targets
mainand deliberately makesReloadhonor a caller-providedsignal, while adding a runtime warning fortransportas a non-breaking stopgap. Whenmainanddevare reconciled, preserve #2655's signal support and this PR's transport prohibition. Remove #2655's transport warning and its warning-specific test.(Written by GPT-5)