fix(android): preserve submenu order and apply iconColor tint - #179
Open
OmerToledo wants to merge 1 commit into
Open
fix(android): preserve submenu order and apply iconColor tint#179OmerToledo wants to merge 1 commit into
OmerToledo wants to merge 1 commit into
Conversation
Use addSubMenu with explicit order index so submenu items stay at the correct position instead of defaulting to order 0. Also apply iconColor to submenu parent icons, matching leaf menu item behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addSubMenu(title)defaults menu item order to0, which moves submenu entries to the front of the menu. Subsequentmenu.getItem(i)then resolves the wrong item (wrong icons, brokenindexPathcallbacks).addSubMenu(Menu.NONE, Menu.NONE, i, title)so submenu order matchescreateContextMenuAction, keeping items at the intended index.iconColortint to submenu parent row icons (leaf items already had this behavior).Testing
Tested in a production app via
patch-packageonreact-native-context-menu-view1.21.0.Made with Cursor