Skip to content

fix(android): preserve submenu order and apply iconColor tint #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OmerToledo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): preserve submenu order and apply iconColor tint #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion android/src/main/java/com/mpiannucci/reactnativecontextmenu/ContextMenuView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,16 @@ private void createContextMenuSubMenu(Menu menu, ReadableMap action, ReadableArr
spannableTitle.setSpan(new CustomTypefaceSpan("", customFont), 0, title.length(), Spanned.SPAN_EXCLUSIVE_INCLUSIVE);
}

Menu parentMenu = menu.addSubMenu(spannableTitle);
// Explicit order (matching createContextMenuAction) so the submenu is inserted at index i
// in the menu's internal item list; addSubMenu(title) alone defaults order to 0, which
// shifts the submenu to the front and makes menu.getItem(i) below target the wrong item.
Menu parentMenu = menu.addSubMenu(Menu.NONE, Menu.NONE, i, spannableTitle);

@Nullable Drawable icon = getResourceWithName(getContext(), action.getString("icon"));
if (action.hasKey("iconColor") && icon != null) {
int color = Color.parseColor(action.getString("iconColor"));
icon.setTint(color);
}
menu.getItem(i).setIcon(icon); // set icon to current item.

for (int j = 0; j < childActions.size(); j++) {
Expand Down