docs: note that an @include fragment owns its leading connector - #23
Merged
Conversation
Add a TIP to the Fragment inclusion section. Because @include rides the parser-comment channel it disappears when a template is pasted verbatim, so the surrounding SQL must be valid without the fragment: the including template places a bare directive after a fixed anchor, and the fragment supplies the connector with its predicate. Moving the connector onto the including side would leave a dangling AND (or empty parentheses when wrapped), so the fragment's leading AND is load-bearing, not stylistic. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YAydPGeSHjZvJv22oz4P6d
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 11 11
Lines 951 951
=======================================
Hits 918 918
Misses 21 21
Partials 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a TIP to the Fragment inclusion section.
Because
@includerides the parser-comment channel, the directive disappears when a template is pasted verbatim into a client, so the surrounding SQL must be valid without the fragment. The including template therefore places a bare directive after a fixed anchor (where 1 = 1 /*%! @include active */) and the fragment supplies the connector with its predicate (/*%if activeOnly*/and status = …/*%end*/). Moving the connector onto the including side (where 1 = 1 and /*%! @include active */) would leave a danglingand, and wrapping it (and (/*%! @include active */)) would leave empty parentheses — so the fragment’s leadingandis load-bearing, not stylistic.🤖 Generated with Claude Code