fix(release-publish-oci): build the tag's code, not the run's checkout - #94
Open
sebasnallar wants to merge 1 commit into
Open
fix(release-publish-oci): build the tag's code, not the run's checkout#94sebasnallar wants to merge 1 commit into
sebasnallar wants to merge 1 commit into
Conversation
The chained pipeline always runs on the main branch — that is what makes it trigger at all — so docker-build-push-ecr's default checkout (the triggering commit) builds main. For a fresh release that coincides with the tagged commit, but in existing_tag recovery or backfill mode main has moved on: the image would carry the old tag over new code. Add a `ref` input to docker-build-push-ecr (empty = triggering commit, fully backward compatible) and have release-publish-oci pass the tag being published in both modes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #93. The chained pipeline runs on the main branch (that's what makes it trigger at all), and
docker-build-push-ecr.ymlchecks out the triggering commit. For a fresh release that's exactly the tagged commit — but inexisting_tagrecovery/backfill mode, main has moved on: the image would be built from today's main and pushed under the old tag.Change
docker-build-push-ecr.yml: new optionalrefinput (checkout ref; empty = the triggering commit, so all existing callers are untouched).release-publish-oci.yml: passes the tag being published asrefin both modes — the built code is always the tag's code, by construction rather than by coincidence.Test plan
existing_tagdispatch for an old tag builds that tag's tree (verify image digest ≠ a main build).🤖 Generated with Claude Code