Skip to content

fix(release-publish-oci): build the tag's code, not the run's checkout #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebasnallar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(release-publish-oci): build the tag's code, not the run's checkout #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/docker-build-push-ecr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ on:
required: false
type: string
default: ''
ref:
description: 'Git ref to check out and build (tag/branch/SHA). Empty = the commit that triggered the run. Pass the tag being published whenever the run context is not the tag itself (e.g. chained release pipelines running on main).'
required: false
type: string
default: ''
outputs:
image_digest:
description: 'OCI image-index digest (sha256:...)'
Expand Down Expand Up @@ -75,6 +80,9 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v6
with:
# Empty ref = actions/checkout default (the triggering commit).
ref: ${{ inputs.ref }}

- name: Set up QEMU
uses: docker/setup-qemu-action@v4
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/release-publish-oci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,11 @@ jobs:
build_args: ${{ inputs.build_args }}
also_tag_latest: ${{ inputs.also_tag_latest }}
tag: ${{ inputs.existing_tag || needs.release.outputs.tag_name }}
# Build the TAG's code, not the run's checkout. The run always sits on
# the main branch (that is what makes the chain trigger at all), which
# coincides with the tagged commit for a fresh release — but never for
# an existing_tag recovery/backfill, where main has moved on.
ref: ${{ inputs.existing_tag || needs.release.outputs.tag_name }}
secrets:
aws_role_arn: ${{ secrets.aws_role_arn }}

Expand Down