Skip to content

docs(components): drop the retired element:filter from the elements.tsx header note - #5847

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-4935-element-filter-residue
Aug 23, 2026
Merged

docs(components): drop the retired element:filter from the elements.tsx header note#5847
os-zhuang merged 1 commit into
mainfrom
claude/issue-4935-element-filter-residue

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Fixes #4935

Comment-only cleanup. The elements.tsx header note listed element:filter among the "heavier interactive elements" said to live in their owning plugins. No such file ever existed for it, and the element was retired at element grain upstream (ADR-0049), so the type is now absent from PageComponentType entirely — the claim was stale twice over.

- * Heavier interactive elements (element:filter, element:form) live in their
- * owning plugins and are left to those packages. element:record_picker — which
- * writes its selection into a page variable — ships alongside in `./record-picker`.
+ * Heavier interactive elements (element:form) live in their owning plugins and
+ * are left to those packages. element:record_picker — which writes its
+ * selection into a page variable — ships alongside in `./record-picker`.

A pure token deletion plus a re-wrap of the paragraph it orphaned.

Scope — residue 2 only; residue 1 was already gone

The card's body names two residues and is stale. PALETTE_EXCLUSIONS['element:filter'] in packages/app-shell/src/views/metadata-admin/previews/block-types.ts was already deleted in #5529, which had to touch that file once the enum member disappeared. Re-measured on origin/main @ d40d2953e: zero element:filter hits in block-types.ts, while element:form still hits that same file on the same grep — so the zero is a real reading of a reachable file, not a wrong-path artefact. Nothing was re-deleted there and this PR does not touch that file.

⛔ Only the element:filter half of the sentence is fixed. The element:form half is objectstack#9249's open question, and the diff above leaves its claim byte-identical apart from where the line wraps. That question is not answered here.

Precondition, counter-probed

PageComponentType, read from the @objectstack/spec pinned in this worktree:

probe result
member count 34
element:text true — known-present control
element:button true — known-present control
element:form true — known-present control
element:filter false
zzNotARealPageComponentType false — never-existed sentinel

Recorded because it matters: the first probe returned false for every key, controls included — it read the package root export instead of the @objectstack/spec/ui subpath. A bare false on the target would have looked like a passing reading. That run was discarded; the table is from the corrected probe.

Repo-wide enumeration, before and after

Same pipeline both times, with element:form as a positive control and element:zzNotAThing as a sentinel (0 hits, as expected).

Before — 7 hits in 6 files. After — 7 hits in 6 files: elements.tsx drops out, this PR's own changeset joins. What survives, and why none of it is sweepable:

survivor why it stays
.changeset/4935-element-filter-comment-residue.md this PR's changeset; it names the token in order to describe the change
.changeset/spec-pin-17-1-0-5328.md landed changeset — a historical record, never rewritten
packages/app-shell/CHANGELOG.md:12391 published CHANGELOG — historical record, never rewritten
docs/audits/2901-spec-enum-renderer-coverage.md:99 a version-anchored audit ("Audited against …", re-validated against a named release). A frozen point-in-time census, same class as a CHANGELOG — not stale prose to fix
…/previews/__tests__/palette-discussion-alias.test.tsx:92 live assertionexpect(specNames).not.toContain('element:filter') is what pins the absence. Removing it would be deleting the guard
packages/test-support/src/__tests__/spec-tombstones.test.ts:242,274 live test comments using element:filter as the discriminating case for tombstone ordering

So elements.tsx:18 was the only removable residue left in the repo.

Verification

Gate union re-run on the final commit 100ecc1b6; the working tree is identical to HEAD (empty git status --porcelain), so the longer runs below cover this same tree.

check result
pnpm exec vitest run — changed dir + the three tests that pin the retirement facts Test Files 5 passed (5), Tests 64 passed (64)
pnpm exec vitest run packages/components/ (whole affected package) Test Files 181 passed (181), Tests 1656 passed (1656)
@object-ui/components lint ✖ 906 problems (0 errors, 906 warnings) — 0 errors; warnings are the pre-existing baseline
@object-ui/components type-check exit 0
check-changeset-presence ✅ … declares 1 changeset(s) — empty frontmatter, the explicit "releases nothing" answer
check-control-bytes ✅ OK (scanned 4869 tracked text file(s))
check-changeset-no-major / check-changeset-fixed both

Two notes on how those readings were taken, since both are traps this repo has been bitten by:

  • vitest was run from the repo root with relative paths and no --; its banner reports the root as the worktree root, so the apps/console 22-file false-green is not in play.
  • the first type-check failed with TS2307: Cannot find module '@object-ui/core' — the unbuilt-dependency trap in a fresh worktree, not this diff. Fixed properly by building the dependency closure (pnpm --filter '@object-ui/components^...' build) and re-running; it is the re-run that reports exit 0.

No ablation, and no decorative substitute for one. This diff is a comment; it has no behavioural leg to remove and no assertion whose red/green could be flipped by reverting it. Staging a reverse-verification here would produce a number that means nothing, so none was run.

Changeset

Empty-frontmatter (--- / ---), declaring that this releases nothing. The changeset gate rejected the diff without one — a comment in a released package's src/ still owes the declaration — and accepts the empty form as a complete answer.


Generated by Claude Code

…eader note

The file header listed `element:filter` among the "heavier interactive elements"
said to live in their owning plugins. No such file ever existed for it, and the
element was retired at element grain upstream (ADR-0049), so the type is now
absent from `PageComponentType` entirely — the claim was stale twice over.

Removes only that token. The `element:form` half of the same sentence is left
exactly as it stands: whether it belongs there is a separate open question, and
this change deliberately does not answer it.

Comment-only, no behaviour change; declared as releasing nothing via an
empty-frontmatter changeset.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EuPCi56cnGyykygi3z9w4m
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 52 chunks) 3228.4 KB 3990.2 KB
Main entry chunk (gzip) 152.8 KB 350 KB
Entry file index-Zf0FAT07.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 10.13KB 3.77KB
app-shell (runtime-config.js) 12.80KB 4.47KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 5.13KB 2.35KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 503.68KB 113.91KB
core (index.js) 4.92KB 1.97KB
create-plugin (index.js) 10.08KB 3.26KB
data-objectstack (index.js) 164.55KB 45.67KB
fields (index.js) 238.40KB 59.89KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.28KB 1.75KB
i18n (index.js) 3.44KB 1.39KB
i18n (pickLocalized.js) 7.62KB 3.26KB
i18n (provider.js) 23.13KB 7.63KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 33.40KB 8.71KB
i18n (useSafeTranslation.js) 7.77KB 3.13KB
layout (index.js) 38.95KB 10.97KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.55KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useResponsiveConfig.js) 1.37KB 0.63KB
mobile (useSpecGesture.js) 4.32KB 1.64KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 9.53KB 3.38KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 4.64KB 1.50KB
permissions (evaluator.js) 5.12KB 1.74KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 1.93KB 0.88KB
plugin-ai (index.js) 15.75KB 3.80KB
plugin-calendar (index.js) 46.62KB 12.83KB
plugin-charts (index.js) 64.66KB 18.32KB
plugin-chatbot (index.js) 186.91KB 44.22KB
plugin-dashboard (index.js) 132.43KB 34.27KB
plugin-designer (index.js) 212.30KB 42.80KB
plugin-detail (index.js) 242.34KB 60.99KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 125.63KB 30.64KB
plugin-gantt (index.js) 164.15KB 39.88KB
plugin-grid (index.js) 200.79KB 54.26KB
plugin-kanban (index.js) 52.93KB 14.60KB
plugin-list (index.js) 111.80KB 27.20KB
plugin-map (index.js) 20.06KB 6.62KB
plugin-markdown (index.js) 13.72KB 4.69KB
plugin-report (index.js) 43.49KB 11.93KB
plugin-timeline (index.js) 26.49KB 7.59KB
plugin-tree (index.js) 8.50KB 2.88KB
plugin-view (index.js) 84.51KB 20.72KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 52.40KB 17.45KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.33KB 0.69KB
react (schema-input.js) 2.32KB 1.24KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 5.41KB 2.34KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 4.93KB 2.24KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 12.13KB 3.65KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 7.54KB 2.63KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.87KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (index.js) 3.88KB 1.85KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 2.59KB 1.31KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 3.40KB 1.71KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review August 23, 2026 15:24
@os-zhuang
os-zhuang added this pull request to the merge queue Aug 23, 2026
Merged via the queue into main with commit da8db03 Aug 23, 2026
23 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-4935-element-filter-residue branch August 23, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop the stale element:filter palette-exclusion entry and the stale elements.tsx comment once the spec pin passes the #9220 retirement

2 participants