docs(components): drop the retired element:filter from the elements.tsx header note - #5847
Merged
Merged
Conversation
…eader note The file header listed `element:filter` among the "heavier interactive elements" said to live in their owning plugins. No such file ever existed for it, and the element was retired at element grain upstream (ADR-0049), so the type is now absent from `PageComponentType` entirely — the claim was stale twice over. Removes only that token. The `element:form` half of the same sentence is left exactly as it stands: whether it belongs there is a separate open question, and this change deliberately does not answer it. Comment-only, no behaviour change; declared as releasing nothing via an empty-frontmatter changeset. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EuPCi56cnGyykygi3z9w4m
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4935
Comment-only cleanup. The
elements.tsxheader note listedelement:filteramong the "heavier interactive elements" said to live in their owning plugins. No such file ever existed for it, and the element was retired at element grain upstream (ADR-0049), so the type is now absent fromPageComponentTypeentirely — the claim was stale twice over.A pure token deletion plus a re-wrap of the paragraph it orphaned.
Scope — residue 2 only; residue 1 was already gone
The card's body names two residues and is stale.
PALETTE_EXCLUSIONS['element:filter']inpackages/app-shell/src/views/metadata-admin/previews/block-types.tswas already deleted in #5529, which had to touch that file once the enum member disappeared. Re-measured onorigin/main@d40d2953e: zeroelement:filterhits inblock-types.ts, whileelement:formstill hits that same file on the same grep — so the zero is a real reading of a reachable file, not a wrong-path artefact. Nothing was re-deleted there and this PR does not touch that file.⛔ Only the
element:filterhalf of the sentence is fixed. Theelement:formhalf is objectstack#9249's open question, and the diff above leaves its claim byte-identical apart from where the line wraps. That question is not answered here.Precondition, counter-probed
PageComponentType, read from the@objectstack/specpinned in this worktree:element:texttrue— known-present controlelement:buttontrue— known-present controlelement:formtrue— known-present controlelement:filterfalsezzNotARealPageComponentTypefalse— never-existed sentinelRecorded because it matters: the first probe returned
falsefor every key, controls included — it read the package root export instead of the@objectstack/spec/uisubpath. A barefalseon the target would have looked like a passing reading. That run was discarded; the table is from the corrected probe.Repo-wide enumeration, before and after
Same pipeline both times, with
element:formas a positive control andelement:zzNotAThingas a sentinel (0 hits, as expected).Before — 7 hits in 6 files. After — 7 hits in 6 files:
elements.tsxdrops out, this PR's own changeset joins. What survives, and why none of it is sweepable:.changeset/4935-element-filter-comment-residue.md.changeset/spec-pin-17-1-0-5328.mdpackages/app-shell/CHANGELOG.md:12391docs/audits/2901-spec-enum-renderer-coverage.md:99…/previews/__tests__/palette-discussion-alias.test.tsx:92expect(specNames).not.toContain('element:filter')is what pins the absence. Removing it would be deleting the guardpackages/test-support/src/__tests__/spec-tombstones.test.ts:242,274element:filteras the discriminating case for tombstone orderingSo
elements.tsx:18was the only removable residue left in the repo.Verification
Gate union re-run on the final commit
100ecc1b6; the working tree is identical to HEAD (emptygit status --porcelain), so the longer runs below cover this same tree.pnpm exec vitest run— changed dir + the three tests that pin the retirement factsTest Files 5 passed (5),Tests 64 passed (64)pnpm exec vitest run packages/components/(whole affected package)Test Files 181 passed (181),Tests 1656 passed (1656)@object-ui/componentslint✖ 906 problems (0 errors, 906 warnings)— 0 errors; warnings are the pre-existing baseline@object-ui/componentstype-checkcheck-changeset-presence✅ … declares 1 changeset(s)— empty frontmatter, the explicit "releases nothing" answercheck-control-bytes✅ OK (scanned 4869 tracked text file(s))check-changeset-no-major/check-changeset-fixed✅bothTwo notes on how those readings were taken, since both are traps this repo has been bitten by:
--; its banner reports the root as the worktree root, so theapps/console22-file false-green is not in play.type-checkfailed withTS2307: Cannot find module '@object-ui/core'— the unbuilt-dependency trap in a fresh worktree, not this diff. Fixed properly by building the dependency closure (pnpm --filter '@object-ui/components^...' build) and re-running; it is the re-run that reports exit 0.No ablation, and no decorative substitute for one. This diff is a comment; it has no behavioural leg to remove and no assertion whose red/green could be flipped by reverting it. Staging a reverse-verification here would produce a number that means nothing, so none was run.
Changeset
Empty-frontmatter (
---/---), declaring that this releases nothing. The changeset gate rejected the diff without one — a comment in a released package'ssrc/still owes the declaration — and accepts the empty form as a complete answer.Generated by Claude Code