Skip to content

docs(components): drop the retired element:filter from the elements.tsx header note #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Aug 23, 2026
+11 −3
Merged

docs(components): drop the retired element:filter from the elements.tsx header note #5847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/4935-element-filter-comment-residue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
---

Comment-only cleanup in `@object-ui/components`: the `elements.tsx` header note no
longer lists `element:filter` among the heavier interactive elements said to live in
their owning plugins. No such file ever existed for it, and the element was retired at
element grain upstream (ADR-0049), so the type is gone from `PageComponentType`
entirely. No published behaviour changes.
6 changes: 3 additions & 3 deletions packages/components/src/renderers/basic/elements.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
* - element:divider (no-props separator)
* - ElementButtonProps -> element:button
*
* Heavier interactive elements (element:filter, element:form) live in their
* owning plugins and are left to those packages. element:record_picker — which
* writes its selection into a page variable — ships alongside in `./record-picker`.
* Heavier interactive elements (element:form) live in their owning plugins and
* are left to those packages. element:record_picker — which writes its
* selection into a page variable — ships alongside in `./record-picker`.
*
* All props are read off `schema.properties` per the spec's
* `UIComponent.properties` convention; `schema.props` is also accepted
Expand Down
Loading