Improve generated code to emit fewer warnings - #122
Open
notpeter wants to merge 5 commits into
Open
Conversation
Additionally, run `clippy --fix` after generation to automatically fix some additional compliants. Manual fixes applied to code generator: - Removed legacy numeric constant imports: e.g. `use std::i32` - Removed unused ExtractJsonMediaType::content_json - Replaced get(...).is_some() with contains_key(...) - Rewrote `operation_id.is_none()` plus `operation_id.as_ref().unwrap()` patterns to `if let Some(operation_id)` - Improved generated doc comments: - Prevent empty doc comments - Use single line comments in more places - Improved markdown ul hanging indent - Remove trailing whitespace in ul - Ensure space following /// - Stop managing trailing periods - Better br stripping - Stop printing warning on every instance of unsupported min/max parameters - Stop complaining for OpenAPI 3.0.0 (not being exactly 3.0.3)
notpeter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously running
makegenerated tens of thousands of cargo warnings. Now it's less.Fixes applied to code generator:
use std::i32operation_id.is_none()plusoperation_id.as_ref().unwrap()patterns toif let Some(operation_id)clippy --fixto reduce clippy complaints on generated code.