feat: prompt for Full Disk Access on the welcome screen - #5
Merged
phalladar merged 1 commit intoOct 3, 2026
Merged
Conversation
petercrocker
marked this pull request as ready for review
October 3, 2026 10:10
Without Full Disk Access, protected folders are skipped and sizes are under-reported with no indication why. macOS has no API to request the permission, so probe a TCC-protected file and, when it cannot be read, show a dismissible banner that opens the Full Disk Access pane in System Settings and offers to relaunch the app. The check re-runs when the app becomes active, so the banner clears once access is granted.
phalladar
force-pushed
the
feat/full-disk-access-prompt
branch
from
October 3, 2026 14:57
3f4b0af to
8f7cb12
Compare
Owner
|
@petercrocker Thanks for this! Without Full Disk Access, macOS hides folders and scans come up short with no explanation, which users can't figure out on their own. This banner fixes that. You'd allowed maintainer edits, so I rebased this onto
Before pushing, I checked that it builds under Swift 6 strict concurrency. I also confirmed the probe behaves as intended without Full Disk Access: the protected files are visible to |
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Without Full Disk Access, macOS silently hides folders such as Mail, Messages and other apps' data, so scans under-report sizes with no explanation. The welcome screen now detects this and walks the user to the right setting.
Depends on #4. Review only the last commit until that merges.
Key Changes
Documentation Updates
Test Plan
scripts/bundle-app.sh --installwith Full Disk Access off: banner appearsswift runfrom a terminal that has Full Disk Access: no banner (the process inherits the terminal's access)🤖 Generated with Claude Code