Add shortcut to settle the open thread

[colonelpanic8]

What Changed

• add thread.settle as a configurable keybinding command with Mod+Shift+X as the default
• show a confirmation dialog for the open thread before settling
• focus the primary action so Enter confirms, while Escape cancels
• preserve Sidebar V2's existing move-to-next-thread behavior after a successful settle
• document the command and cover default/resolution behavior with tests

Why

Settling the thread currently requires targeting a hover-only sidebar action. A global shortcut makes this frequent lifecycle action available without leaving the keyboard, while the focused confirmation prevents accidental settles and makes the confirmation keystroke explicit.

UI Changes

The shortcut opens an in-app alert dialog naming the thread and explaining that it moves out of active work. The Settle thread button is the initial focus target and displays an Enter key hint; Escape cancels.

Exact-head browser verification completed in an isolated environment against a disposable thread; the focused confirmation state is shown below.

Checklist

• vp check
• vp run typecheck
• vp test apps/web/src/keybindings.test.ts apps/server/src/keybindings.test.ts
• vp run --filter @t3tools/web build

Exact-head evidence

Revalidated at 2d4990a: focused tests, vp check, and vp run typecheck passed. Integrated browser verification confirmed Mod+Shift+X opens the settle dialog from the focused composer while preserving draft text, and Mod+Shift+Enter no longer triggers settlement. The capture uses only disposable local projects.

---

Note

Medium Risk
Touches thread lifecycle navigation and keyboard handling in both sidebars; mistakes could mis-route after settle or settle ineligible threads, though confirmation and extensive unit tests mitigate this.

Overview
Adds thread.settle (Mod+Shift+X, !terminalFocus) to contracts, shared defaults, server bootstrap tests, and user keybinding docs.

resolveThreadSidebarShortcutAction centralizes thread shortcut handling for both sidebars: navigate, open settle confirmation, consume (ineligible route, in-flight settle, or modal open), or ignore. While a settle dialog is open, other thread shortcuts are consumed so the route does not change behind it.

Legacy and V2 sidebars wire the shortcut to an AlertDialog (Enter on the focused “Settle thread” action, Escape cancels). On confirm they call settleThread and, if you are still on that thread, advance via resolveNextActiveThreadIdAfterSettle (visible order first, full unarchived list as fallback), skipping effectively settled and snoozed threads—or start a new thread when none remain. Shortcut handling is skipped when the command palette or model picker is open.

Supporting changes in Sidebar.logic: PR/change-request state for hidden or collapsed rows (git cwd resolution, worktree-only git queries, pending-state publish rules), shared effective settled/snooze helpers, and confirmation dismiss rules. Visible rows report PR state upward for auto-settle classification.

^{Reviewed by Cursor Bugbot for commit 0b21321. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add thread.settle keyboard shortcut (Mod+Shift+X) to settle the open thread from the sidebar

• Adds thread.settle to the keybinding system, bound to Mod+Shift+X with !terminalFocus, in both shared keybindings and contracts.
• Introduces resolveThreadSidebarShortcutAction in keybindings.ts to classify thread shortcuts into none, consume, navigate, or confirm-settle outcomes, replacing direct traversal/jump index logic.
• Both Sidebar.tsx and SidebarV2.tsx now show an AlertDialog confirmation before settling; on confirm, the thread is settled and the sidebar navigates to the next active thread or opens a new one.
• Adds hidden SidebarHiddenThreadChangeRequestStateReporter components to track per-thread PR/change-request state for threads not currently visible in the sidebar, used to determine effective settlement state.
• Keyboard shortcut handling is suppressed when the command palette or model picker is open.

^{Macroscope summarized 0b21321.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 38e4f40b-f610-4e24-ac88-91c13c002385

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

New feature adding a keyboard shortcut to settle threads, with confirmation dialog and post-settle navigation logic across both sidebar implementations. New user-facing capabilities warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Closing in favor of merged #8089. It adds the configurable thread.settle shortcut and uses the same shortcut to settle or restore the active thread. Your work is credited in #8089.