Skip to content

feat(web): add thread.settle keyboard shortcut (mod+shift+s) - #4876

Closed
jbmcguire wants to merge 1 commit into
pingdotgg:mainfrom
jbmcguire:feat/thread-settle-keybinding
Closed

feat(web): add thread.settle keyboard shortcut (mod+shift+s)#4876
jbmcguire wants to merge 1 commit into
pingdotgg:mainfrom
jbmcguire:feat/thread-settle-keybinding

Conversation

@jbmcguire

@jbmcguire jbmcguire commented Jul 29, 2026

Copy link
Copy Markdown

What Changed

Adds a thread.settle keybinding command so the active thread can be settled from the keyboard. Default binding is mod+shift+s with when: !terminalFocus.

  • packages/contracts/src/keybindings.ts: new thread.settle command in THREAD_KEYBINDING_COMMANDS
  • packages/shared/src/keybindings.ts: default mod+shift+s binding (server startup sync distributes it to existing configs)
  • apps/web/src/routes/_chat.tsx: global handler dispatches the command for the current route thread via useThreadActions().settleThread, so the existing can-settle guardrails and version-skew checks apply; failures surface with the same toast pattern the sidebar uses, and settling stays on the thread
  • Tests: default-binding + shortcut-resolution coverage in apps/web/src/keybindings.test.ts and apps/server/src/keybindings.test.ts
  • Docs: docs/user/keybindings.md defaults and command list

The Keybindings settings panel picks the command up automatically (label "Thread: Settle"), and it is rebindable like any other command.

Why

Settling is a high-frequency lifecycle action but was mouse-only (sidebar hover controls). A keyboard shortcut makes triaging threads much faster. mod+shift+s has no conflicts with existing defaults (mod+s remains composer stash) or hardcoded handlers.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes (n/a — no visual change)
  • I included a video for animation/interaction changes (n/a)

🤖 Generated with Claude Code

Note

Add thread.settle keyboard shortcut (mod+shift+s) to chat route

Macroscope summarized ac062ed.

Adds a thread.settle keybinding command so the active thread can be
settled from the keyboard. Defaults to mod+shift+s outside terminal
focus, reuses useThreadActions' settleThread (so the existing
can-settle guardrails and version-skew checks apply), and surfaces
failures via the standard toast. Documented in docs/user/keybindings.md.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cb9ee101-ff34-4714-8895-614626ff7a36

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 29, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved ac062ed

This PR adds a keyboard shortcut to expose existing thread.settle functionality. The implementation follows established patterns in the codebase, includes comprehensive tests, and updates documentation. No new runtime behavior is introduced beyond the keybinding trigger.

You can customize Macroscope's approvability policy. Learn more.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac062eda38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

export const THREAD_KEYBINDING_COMMANDS = [
"thread.previous",
"thread.next",
"thread.settle",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep new keybinding commands backward-compatible

When a newer server starts, it backfills thread.settle into its persisted defaults and includes that rule in ServerConfig.keybindings; an older desktop/mobile/web client still decodes this field with the previous closed KeybindingCommand literal union, so the unknown command causes initial config decoding to fail and prevents that client from connecting. This affects common remote version-skew scenarios, so the wire decoder needs to tolerate/filter commands unknown to the client, or the server must avoid sending them to older clients.

AGENTS.md reference: AGENTS.md:L19-L21

Useful? React with 👍 / 👎.

@pkelaita

Copy link
Copy Markdown

+1 to this PR, would love to see this feature. Huge for productivity!

@jonalmar

Copy link
Copy Markdown

I would use this daily. A default Command-Shift-S shortcut for settling the active thread would improve my workflow.

@t3dotgg

t3dotgg commented Aug 25, 2026

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Closing in favor of merged #8089. It adds the configurable thread.settle shortcut and uses the same shortcut to settle or restore the active thread. Your work is credited in #8089.

@t3dotgg t3dotgg closed this Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants