Skip to content

Julenmendieta/MILAB-5768_renameLabel - #40

Merged
julenmendieta merged 6 commits into
mainfrom
julenmendieta/MILAB-5768_renameLabel
Mar 18, 2026
Merged

Julenmendieta/MILAB-5768_renameLabel#40
julenmendieta merged 6 commits into
mainfrom
julenmendieta/MILAB-5768_renameLabel

Conversation

@julenmendieta

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on refining the terminology used within the workflow templates by renaming 'Clone label' to 'Clone Id', enhancing the precision of data representation. Concurrently, it modernizes the development environment by integrating the Oxc formatter into VS Code settings and updating various project dependencies, aiming to improve code consistency and developer experience.

Highlights

  • Clonotype Label Renaming: The 'Clone label' field in both bulk and single-cell processing workflow templates has been updated to 'Clone Id' for improved clarity and consistency.
  • VS Code Tooling Update: The default formatter in VS Code has been switched from dbaeumer.vscode-eslint to oxc.oxc-vscode across various file types, and the Oxc extension has been added to recommendations. Tab size settings were also standardized for several languages.
  • Dependency and Catalog Updates: Several @platforma-sdk package versions were updated in pnpm-workspace.yaml, @milaboratories/ts-builder was added as a dependency and to the catalog, and oxlint and oxfmt were introduced as peer dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request has two main purposes. First, it introduces the oxc tool for linting and formatting, updating the VS Code settings and project dependencies accordingly. Second, it renames the display name for a clonotype property from 'Clone label' to 'Clone Id'. My review focuses on the latter change, suggesting improvements to the property's description in process-bulk.tpl.tengo and process-single-cell.tpl.tengo to ensure consistency and avoid user confusion with another existing 'Clonotype ID' field.

Comment thread workflow/src/process-bulk.tpl.tengo Outdated
Comment thread workflow/src/process-single-cell.tpl.tengo
@julenmendieta
julenmendieta added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit f65ff48 Mar 18, 2026
8 checks passed
@julenmendieta
julenmendieta deleted the julenmendieta/MILAB-5768_renameLabel branch March 18, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant