Skip to content

Julenmendieta/MILAB-6246_labelVisibility - #43

Merged
julenmendieta merged 2 commits into
mainfrom
julenmendieta/MILAB-6246_labelVisibility
May 8, 2026
Merged

Julenmendieta/MILAB-6246_labelVisibility#43
julenmendieta merged 2 commits into
mainfrom
julenmendieta/MILAB-6246_labelVisibility

Conversation

@julenmendieta

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request ensures that the 'Clone Id' axis label is visible by default across VDJ import workflows. Changes include adding a visibility annotation in the bulk processing template and updating a flag in the single-cell template. Feedback suggests using the 'a' helper function in the bulk template for better consistency and to ensure correct order priority.

Comment on lines 289 to 293
annotations: {
"pl7.app/label": "Clone Id",
"pl7.app/description": "A short, human-readable identifier for the clonotype."
"pl7.app/description": "A short, human-readable identifier for the clonotype.",
"pl7.app/table/visibility": "default"
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other column definitions in this file and with process-single-cell.tpl.tengo, it is recommended to use the helper function a (defined at line 20) instead of manually defining the annotations map. This also ensures that the orderPriority is consistently applied to the clonotype label column.

                    annotations: a(100000, true, {
                        "pl7.app/label": "Clone Id",
                        "pl7.app/description": "A short, human-readable identifier for the clonotype."
                    })

@julenmendieta
julenmendieta added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit ba1f538 May 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant