Skip to content

fix: display the native Pro SEO integrations on the Integrations screen (#143) - #144

Merged
ifahimreza merged 1 commit into
mainfrom
fix/143-integrations-screen-seo-rows
Aug 24, 2026
Merged

fix: display the native Pro SEO integrations on the Integrations screen (#143)#144
ifahimreza merged 1 commit into
mainfrom
fix/143-integrations-screen-seo-rows

Conversation

@ifahimreza

Copy link
Copy Markdown
Contributor

Closes #143

What

The Detected integrations panel gains display entries for Yoast SEO, Rank Math and AIOSEO, and row keys now try the two-segment prefix first (fixing the would-be 'rank' row from split('-')[0]). Tracked admin bundle rebuilt.

Why

Companion to saddle-pro#74/#75: Pro 1.5.0's native SEO tools now group under Integrations via the existing saddle_integration_ui_prefixes filter, but this screen had no names for them.

How

Rows stay honest — Pro adds a prefix only while that plugin is detected, so a row here always reflects a plugin that is really present. JS-only; no PHP surface change; ships with free 1.1.0 after .org approval (visible immediately on symlinked dev sites).

Testing

  • npm run lint:js clean, bundle rebuilds
  • Live on plug.press with Yoast installed: 'Yoast SEO — 7 tools' row renders with description; without the plugin, no row
  • No PHP changes; free suite unaffected

🤖 Generated with Claude Code

https://claude.ai/code/session_016T8VZT8Y1dqGViKqKUoYNh

…screen

KNOWN gains Yoast SEO / Rank Math / AIOSEO display entries, and row keys
now try the two-segment prefix against KNOWN first, so rank-math-* files
under 'Rank Math' instead of a row named 'rank'. Rows only appear when the
plugin is really present: Saddle Pro gates its saddle_integration_ui_prefixes
hook on detection, so this stays an honest 'Detected integrations' list.
Tracked admin bundle rebuilt.

Closes #143
@ifahimreza
ifahimreza merged commit 565e323 into main Aug 24, 2026
1 of 7 checks passed
@ifahimreza
ifahimreza deleted the fix/143-integrations-screen-seo-rows branch August 24, 2026 19:21
ifahimreza added a commit that referenced this pull request Aug 24, 2026
Saddle Pro's saddle_integration_ui_prefixes hook contributes four
detection-gated prefixes, not three: yoast-, rank-math-, aioseo- and wc-.
#144 gave KNOWN display entries to the three SEO ones and missed the
store, so a Pro + WooCommerce site rendered a row titled literally "wc"
with an empty description via detectIntegrations()'s fallback.

Also regenerates languages/saddle.pot, which was last built on 08-21 and
so was missing #144's six SEO msgids alongside these two.

Closes #146
ifahimreza added a commit that referenced this pull request Aug 24, 2026
Saddle Pro's saddle_integration_ui_prefixes hook contributes four
detection-gated prefixes, not three: yoast-, rank-math-, aioseo- and wc-.
#144 gave KNOWN display entries to the three SEO ones and missed the
store, so a Pro + WooCommerce site rendered a row titled literally "wc"
with an empty description via detectIntegrations()'s fallback.

Also regenerates languages/saddle.pot, which was last built on 08-21 and
so was missing #144's six SEO msgids alongside these two.

Closes #146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrations screen: display the native Pro SEO integrations (free half)

1 participant