chore: bump cosmos/evm pin to v0.6.2 - #352
Merged
Merged
Conversation
Points the evm replace at push-chain-evm develop f6a1ba72, which is cosmos/evm v0.6.2. No node code changes were required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the evm
replaceat push-chain-evmdevelopf6a1ba72 (cosmos/evm v0.6.2), up from2d248e1881bb(v0.6.0).Changes required: none
go.mod+go.sumonly — 2 files, 3 lines. No node code changes were needed. No migration, no protochange, no
ConsensusVersionbump (the evm side had none either).Tests
go build ./...clean.go test -p 1 -count=1 -tags="ledger test_ledger_mock test" ./x/... ./test/integration/...→ exit 0, 17 packages ok, 0 FAIL, including
test/integration/uexecutor(15.0s).The thing this PR was really checking: the module-account guard
cosmos/evm v0.6.1 added a security guard (private fork merge
3524ebc6) inSetBalanceWithLocked:This mattered because Push makes EVM calls from the
uemodule account (isModuleSender=true, 4 sitesin
x/uexecutor/keeper/evm.go),ueis a genuineModuleAccountI(GetModuleAccount(ctx, "ue"),registered Minter+Burner at
app/app.go:267), andstatedb.Commit→SetAccount→SetAccountBalanceruns for every dirty account.
Empirically it does not fire. Verified:
x/vm/keeper/statedb.go:164) — this is not a case of the fixbeing absent
not allowed to receive fundsacross the whole suitetest/integration/uexecutorInferred mechanism, not proven:
SetBalanceWithLockedstarts withif amount == nil { return nil },above the guard, so a dirty account whose balance was never read or written skips it. That fits a module
sender that only bumps its nonce and sends
value=0.is worth doing before this reaches a live network.
Note on scope
This is the
developline, which pins cosmos-sdk v0.53.7. Theaudit-fixesline pins v0.50.10 and adifferent evm commit; it is unaffected by this PR.