Skip to content

Fixed MSVC compile errors (backport #3135) - #3173

Merged
skyegalaxy merged 1 commit into
jazzyfrom
marcoag/backport-rclcpp-3135
Jun 11, 2026
Merged

Fixed MSVC compile errors (backport #3135)#3173
skyegalaxy merged 1 commit into
jazzyfrom
marcoag/backport-rclcpp-3135

Conversation

@marcoag

@marcoag marcoag commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

EventsCBGExecutor was backported to jazzy by #3163 without the RCLCPP_PUBLIC making rclcpp fail to link on Windows.

This PR cherry-picks #3135, which:

  • adds RCLCPP_PUBLIC
  • replaces the deprecated std::shared_ptr::unique() with use_count() == 1

Is this user-facing behavior change?

The export additions are additive. The other change is internal

Did you use Generative AI?

No

@jmachowinski Janosch Machowinski @marcoag
fix: Fixed MSVC compile errors (#3135)
f59b2e3 
Signed-off-by: Janosch Machowinski <JMachowinski@cellumation.com>
Co-authored-by: Janosch Machowinski <JMachowinski@cellumation.com>
(cherry picked from commit 45aef03)
Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com>
@marcoag

marcoag commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: #3173
Gist: https://gist.githubusercontent.com/marcoag/152c5a3194d328a136891ea5337fbf1d/raw/c20d27faea699ee46eb687ddb04bbadadd2e57cd/backport-rclcpp-3135.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: jazzy
Job: ci_launcher
ci Launcher ran: https://ci.ros2.org/job/ci_launcher/19514/

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@marcoag marcoag mentioned this pull request Jun 10, 2026
Merged
@marcoag
marcoag requested a review from skyegalaxy June 10, 2026 12:35
@jmachowinski

jmachowinski commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Hu ? Didn't we stop shipping jazzy windows binaries ?

@fujitatomoya

fujitatomoya commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Didn't we stop shipping jazzy windows binaries ?

is this true? i am not aware of that... maybe just missed? 🤔

@fujitatomoya

fujitatomoya commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Pulls: #3173
Gist: https://gist.githubusercontent.com/fujitatomoya/48fc724771c28c0d3892a1f81a7679dc/raw/7ff69c4c4afbeda69a1a84192fb955bb476842d2/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19515

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@skyegalaxy

skyegalaxy commented Jun 10, 2026

Copy link
Copy Markdown
Member

Didn't we stop shipping jazzy windows binaries ?

is this true? i am not aware of that... maybe just missed? 🤔

since Windows 10 went EoL, only windows 11 has been available on the buildfarm and we've not been able to support the release of new windows binaries since our runners haven't been able to compile on jazzy. This patch will allow building from source on Windows again, but CI isn't expected to pass for Windows.

@marcoag

marcoag commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Rerunning RHEL and Windows on VS 2019 (wanna see how far it gets).

  • Linux-rhel Build Status
  • Windows Build Status

@skyegalaxy
skyegalaxy merged commit 0df91fc into jazzy Jun 11, 2026
3 checks passed
@tier4-autoware-public-bot tier4-autoware-public-bot Bot mentioned this pull request Jun 11, 2026
Merged
@ahcorde
ahcorde deleted the marcoag/backport-rclcpp-3135 branch June 12, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skyegalaxy skyegalaxy skyegalaxy approved these changes
@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcoag @jmachowinski @fujitatomoya @skyegalaxy