Rollup of 9 pull requests - #161533
Merged
Merged
Conversation
Only `iterate_to_fixpoint` requires `Domain: DebugWithContext<Self>`; `visit_results` does not. And `Borrowck` is an unusual analysis that never calls `iterate_to_fixpoint`; instead its results are composed from the results of the three sub-analyses.
Installing cargo tools (`cargo install`) without locked dependencies exposes users to supply-chain attacks to all the dependencies of the tool (https://blog.rust-lang.org/2026/08/20/supply-chain-attack-on-arrayref/). Using `cargo install --locked` reduces this risk to a compromise of the tool itself, while using the locked and hashed version of the dependencies. I went through all `rg "cargo install"` hits in the repository and added `--locked` to all but explanatory examples. I validated that those tools publish functioning `Cargo.lock`s with https://gist.github.com/konstin/ef3412518e207bea6035a1bd01f3821b.
…ed free const in the `core::char`/`std::char` modules.
…p building LLVM Because when we do e.g. `x check library`, during that invocation we build the compiler, and that needs LLVM.
After the removal of `ensure_sufficient_stack`, these inner and outer functions no longer need to be separate.
This reverts commit ce9a8ca.
This reverts commit f7fcb54.
…=jieyouxu Fix checking of LLVM prebuilt status This regressed in rust-lang#160916. I'll start from the end. There was a pre-existing bug (fixed by the second commit of this PR), where if we do `x check library`, we have `builder.kind == Kind::Check`, but we are actually building things (like the compiler) during that bootstrap invocation. But bootstrap was only checking the builder kind before, and in that case it would skip building LLVM, *unless* it was already built locally previously. On PR CI, and perhaps always (because build steps executed during check likely only occur during `x check library`, which requires *building* the compiler anyway), the LLVM was built locally anyway, so this bug was hidden away. This also removes an unnecessary LLVM build when running Clippy on the rustc_private tools. However, after rust-lang#160916, this was no longer case, because it stopped treating locally built LLVM as being prebuilt (which, in and of itself, is kinda a bug). Because when we check the compiler, we want to avoid building (and checking out!) LLVM. Before rust-lang#160916, bootstrap considered a *previously locally built* LLVM to be available as a prebuilt `llvm-config`, and in that case configured `LLVM_CONFIG` for `rustc_llvm`. Because all PR CI bootstrap invocations that do `check` actually built LLVM prior doing a build, this worked, somehow, but broke after my PR. Should unblock rust-lang#161466. r? jieyouxu
…xt-for-BorrowckDomain, r=cjgillot Remove `impl DebugWithContext for BorrowckDomain` Only `iterate_to_fixpoint` requires `Domain: DebugWithContext<Self>`; `visit_results` does not. And `Borrowck` is an unusual analysis that never calls `iterate_to_fixpoint`; instead its results are composed from the results of the three sub-analyses. r? @cjgillot
…ter, r=hanna-kruppe Doclink to `char::REPLACEMENT_CHARACTER` instead of `std::char::REPLACEMENT_CHARACTER`. Doclink to the associated const on primitive `char`, not the deprecated free const in the `core::char`/`std::char` modules.
…d, r=folkertdev Install cargo tools with locked dependencies Installing cargo tools (`cargo install`) without locked dependencies exposes users to supply-chain attacks to all the dependencies of the tool (https://blog.rust-lang.org/2026/08/20/supply-chain-attack-on-arrayref/). Using `cargo install --locked` reduces this risk to a compromise of the tool itself, while using the locked and hashed version of the dependencies. I went through all `rg "cargo install"` hits in the repository and added `--locked` to all but explanatory examples (such as cargo's docs on `cargo install` itself). I validated that those tools publish functioning `Cargo.lock`s with https://gist.github.com/konstin/bcb1169c1c1120c259dca64e777a64d0.
Clean up a few `_inner` functions after `ensure_sufficient_stack` After the removal of `ensure_sufficient_stack` in rust-lang#160535, these inner and outer functions no longer need to be separate. cc @ChrisDenton
…ck, r=mejrs Remove useless `!fields.is_empty()` check
enable next solver in Miri This was disabled in rust-lang#160619, apparently because some tests failed. But I can't reproduce those test failures locally. Fixes rust-lang/miri#5269 Landing this here because rustc CI is where this used to break, and also Miri got broken again so we can't do syncs currently. Cc @Kivooeo r? @lcnr
Revert rust-lang#161236 (Download auto jobs in citool in parallel) I think that this might have caused [this failure](rust-lang#161260 (comment)). It's not worth debugging things like that over parallelizing this... r? jieyouxu
rename `T-libs-api` to `T-libs` in issue templates Since they were merged with rust-lang/rfcs#3984.
rustbot
added
A-attributes
rustbot
added
T-infra
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 22, 2026
Rollup of 9 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Aug 22, 2026
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing b0ca9c7 (parent) -> 78c04b6 (this PR) Test differencesShow 6 test diffs6 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 78c04b6a348438fb9396b8864cd34f92fb99cd53 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (78c04b6): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (secondary 15.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 469.195s -> 468.574s (-0.13%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: b0ca9c7124 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
impl DebugWithContext for BorrowckDomain#161269 (Removeimpl DebugWithContext for BorrowckDomain)char::REPLACEMENT_CHARACTERinstead ofstd::char::REPLACEMENT_CHARACTER. #161419 (Doclink tochar::REPLACEMENT_CHARACTERinstead ofstd::char::REPLACEMENT_CHARACTER.)_innerfunctions afterensure_sufficient_stack#161502 (Clean up a few_innerfunctions afterensure_sufficient_stack)!fields.is_empty()check #161507 (Remove useless!fields.is_empty()check)T-libs-apitoT-libsin issue templates #161518 (renameT-libs-apitoT-libsin issue templates)r? @ghost
Create a similar rollup