Document safety requirements for intrinsic fallbacks - #163141
Merged
Merged
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 27, 2026
…Mark-Simulacrum Document safety requirements for intrinsic fallbacks This PR mainly adds `# Safety` section for fallback methods and then clarifies the correspondence between the parameters. In PR rust-lang#158383 I duplicated the safety requirement and was closed. So I try to avoid redundance and only add necessary information.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 28, 2026
Rollup of 11 pull requests Successful merges: - #163085 (Suggest similarly named modules in import paths) - #163098 ([debugger visualizers] Add workaround to read `Rc` strong/weak counts) - #163120 (ci: make musl.sh look for patches next to the script) - #163301 (Fix unused_must_use for scenario which may need to keep value) - #163307 (Less `SpanData` in diagnostics) - #152972 (implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]) - #162536 (Implement Default for NumBuffer) - #163141 (Document safety requirements for intrinsic fallbacks) - #163384 (Various clean-ups around `LayoutCalculator`) - #163405 (Remove some #[linkage] options) - #163413 (mailmap: add Matilde Morrone)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 28, 2026
Rollup of 11 pull requests Successful merges: - #163085 (Suggest similarly named modules in import paths) - #163098 ([debugger visualizers] Add workaround to read `Rc` strong/weak counts) - #163120 (ci: make musl.sh look for patches next to the script) - #163301 (Fix unused_must_use for scenario which may need to keep value) - #163307 (Less `SpanData` in diagnostics) - #163389 (`rustc_builtin_macros` cleanup, part 7) - #152972 (implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]) - #162536 (Implement Default for NumBuffer) - #163141 (Document safety requirements for intrinsic fallbacks) - #163384 (Various clean-ups around `LayoutCalculator`) - #163413 (mailmap: add Matilde Morrone)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 28, 2026
Rollup merge of #163141 - yilin0518:fallback-safety-docs, r=Mark-Simulacrum Document safety requirements for intrinsic fallbacks This PR mainly adds `# Safety` section for fallback methods and then clarifies the correspondence between the parameters. In PR #158383 I duplicated the safety requirement and was closed. So I try to avoid redundance and only add necessary information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly adds
# Safetysection for fallback methods and then clarifies the correspondence between the parameters. In PR #158383 I duplicated the safety requirement and was closed. So I try to avoid redundance and only add necessary information.