Rollup of 11 pull requests by jhpratt · Pull Request #163419 · rust-lang/rust

jhpratt · 2026-09-28T01:51:49Z

Successful merges:

Suggest similarly named modules in import paths #163085 (Suggest similarly named modules in import paths)
[debugger visualizers] Add workaround to read Rc strong/weak counts #163098 ([debugger visualizers] Add workaround to read Rc strong/weak counts)
ci: make musl.sh look for patches next to the script #163120 (ci: make musl.sh look for patches next to the script)
Fix unused_must_use for scenario which may need to keep value #163301 (Fix unused_must_use for scenario which may need to keep value)
Less SpanData in diagnostics #163307 (Less SpanData in diagnostics)
rustc_builtin_macros cleanup, part 7 #163389 (rustc_builtin_macros cleanup, part 7)
implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N] #152972 (implement PartialEq<VecDeque> for Vec, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N])
Implement Default for NumBuffer #162536 (Implement Default for NumBuffer)
Document safety requirements for intrinsic fallbacks #163141 (Document safety requirements for intrinsic fallbacks)
Various clean-ups around LayoutCalculator #163384 (Various clean-ups around LayoutCalculator)
mailmap: add Matilde Morrone #163413 (mailmap: add Matilde Morrone)

…tialEq output

Instead of hardcoding the container layout assuming that the local patches are in /build, look for them next to the script. This helps downstream distros to run this script if their container layout is different and they don't put the musl working dir in /build. This might be an unexpected change for some dowstream distros that were using this script from another directory,but arranged for the patches to still be in `/build`

It's a cut down version of `rustc_errors::DiagInner` that avoids `Span`. It exists because `Span` used to not impl `Send` and so couldn't be sent from codegen threads to the main thread. But that's no longer true and we can send `DiagInner`s directly now.

By just storing `lo` and `hi` instead.

This whole section of the code deals with constructing an alternative layout, but large nesting makes the control flow seem more complex than it actually is.

Constructing these error variants is basically free

Having the generic list span multiple lines is quite jarring, and imo easy to confuse with the parameter list at a glance.

There are already way too many helpers to construct paths in this crate and this one is not very useful.

In all cases, the passed span was already the span of the ident.

Improves consistency, and hopefully clarifies the purpose of previously-mysteriosly named methods like `univariant`.

Most of these cases were found by searching for uses of `DUMMY_NODE_ID`.

Also inline `lambda0` and `lambda1` since they're only used once and are trivial wrappers around `lambda`.

It is much more similar to the methods there than to the methods in `base.rs`.

`new_inputs` and `idents` are never read anywhere, several other `Vec`s are supposed to be `ThinVec`s instead.

jhpratt · 2026-09-28T01:52:03Z

@bors r+ p=5 force

rust-bors · 2026-09-28T01:52:06Z

📌 Commit f53ebb9 has been approved by jhpratt

It is now in the queue for this repository.

rust-bors · 2026-09-28T07:16:51Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 5m 5s
Pushing 28b6e69 to main...

github-actions · 2026-09-28T07:20:32Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2269776 (parent) -> 28b6e69 (this PR)

Test differences

Show 39 test diffs

Stage 1

[ui] tests/ui/imports/nested-module-typo-inaccessible-issue-131366.rs: [missing] -> pass (J1)
[ui] tests/ui/imports/nested-module-typo-issue-131366.rs: [missing] -> pass (J1)
[ui] tests/ui/lint/unused/must-use-lock-guard-issue-162843.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/imports/nested-module-typo-inaccessible-issue-131366.rs: [missing] -> pass (J2)
[ui (polonius)] tests/ui/imports/nested-module-typo-issue-131366.rs: [missing] -> pass (J2)
[ui (polonius)] tests/ui/lint/unused/must-use-lock-guard-issue-162843.rs: [missing] -> pass (J2)
vec_deque::test_partial_eq_vecdeque_reverse: [missing] -> pass (J4)

Stage 2

[ui] tests/ui/imports/nested-module-typo-inaccessible-issue-131366.rs: [missing] -> pass (J0)
[ui] tests/ui/imports/nested-module-typo-issue-131366.rs: [missing] -> pass (J0)
[ui] tests/ui/lint/unused/must-use-lock-guard-issue-162843.rs: [missing] -> pass (J0)
vec_deque::test_partial_eq_vecdeque_reverse: [missing] -> pass (J3)

Additionally, 28 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 28b6e691688c15cef4c60d9044274e7b84397870 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-i686-gnu-nopt-1: 1h 27m -> 2h 20m (+60.5%)
test-x86_64-gnu: 1h 38m -> 2h 36m (+59.6%)
test-x86_64-msvc-ext1: 1h 32m -> 2h 20m (+52.3%)
dist-loongarch64-musl: 1h 23m -> 2h 4m (+49.7%)
dist-x86_64-msvc: 2h 3m -> 3h 3m (+48.7%)
test-i686-gnu-nopt-2: 2h 22m -> 1h 22m (-42.0%)
dist-i686-linux: 1h 20m -> 1h 53m (+39.8%)
test-aarch64-apple-macos-26-2: 1h 52m -> 2h 35m (+38.0%)
test-x86_64-gnu-nopt: 1h 52m -> 2h 34m (+37.1%)
test-x86_64-msvc-ext2: 1h 51m -> 1h 10m (-36.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-09-28T08:00:50Z

Finished benchmarking commit (28b6e69): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.8%, secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.7%, 2.0%]	2
Regressions ❌ (secondary)	2.0%	[1.2%, 2.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-6.9%, -0.5%]	5
All ❌✅ (primary)	1.8%	[1.7%, 2.0%]	2

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.806s -> 488.07s (-0.35%)
Artifact size: 406.32 MiB -> 406.39 MiB (0.02%)

rust-bors · 2026-09-28T08:21:56Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#163085	Suggest similarly named modules in import paths	`7566673afe9bb10977756c59a4d2350eb0557590` (link)
#163098	[debugger visualizers] Add workaround to read `Rc` strong/w…	`3f3412708c47d18d950d9247642cf7d185d6c405` (link)
#163120	ci: make musl.sh look for patches next to the script	`bb1d35ff528702e7a2e4ee86eff864cfeb10f848` (link)
#163301	Fix unused_must_use for scenario which may need to keep val…	`42b3b8369979c235ac13a3ade333f5d20efab5c9` (link)
#163307	Less `SpanData` in diagnostics	`9ad9d62ed45e1cf74841e51583f1f5a2d2c01ff0` (link)
#163389	`rustc_builtin_macros` cleanup, part 7	`6de1fe1e51f51eb9b1185976e9174aa43c3d8c5c` (link)
#152972	implement PartialEq<VecDeque> for Vec, &[T], &mut [T]…	`ff894268ceeeaa9e69e1f72e05f3798810efcc0a` (link)
#162536	Implement Default for NumBuffer	`0e1b7e7b14455ea68021c7a4ceddc1751c51616a` (link)
#163141	Document safety requirements for intrinsic fallbacks	`bacfcfec1f757c234b4ea6b0a4ab9c5a956185a8` (link)
#163384	Various clean-ups around `LayoutCalculator`	`a08577f93f0c4b446e83f0558c0a53ebe4d58533` (link)
#163413	mailmap: add Matilde Morrone	`bef720f90e624ff0e617eb6d290475208917c263` (link)

parent commit: 22697761c6

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

iAeternus and others added 30 commits August 25, 2026 09:25

alloc: make VecDeque partial equality symmetric with vec/slice/array

835975a

resolve too_generic_eval_ice stderr conflict

b50d79a

update assert-ne-no-invalid-help-issue-146204.stderr for VecDeque Par…

8cdd010

…tialEq output

update VecDeque PartialEq stability metadata

3d3f2f8

fix stability attributes for VecDeque PartialEq impls

9942d36

Add regression tests for import module typo suggestions

73bafeb

Suggest similarly named modules in import paths

02db8ad

add workaround to read Rc strong/weak counts

b799651

Document safety requirements for intrinsic fallbacks

398b396

Add regression test for lock guard must-use suggestions

391ff91

Remove the SpanData in InlineAsmError

f01eea5

By just storing `lo` and `hi` instead.

fix unused_must_use suggestion for scenario which may need to keep value

d35f696

Filter with accessbility before find match for name

8f40c2a

introduce generic_param_to_arg helper

46d3d7e

Use a let-chain

284af39

This whole section of the code deals with constructing an alternative layout, but large nesting makes the control flow seem more complex than it actually is.

Remove needless laziness

d2b3f9b

Constructing these error variants is basically free

Move complex clauses to the where clause

6c333a9

Having the generic list span multiple lines is quite jarring, and imo easy to confuse with the parameter list at a glance.

remove the path! macro

12f4d4e

There are already way too many helpers to construct paths in this crate and this one is not very useful.

add generics_without_defaults helper

345eb2c

add item_trait_impl helper

d9b202f

remove redundant span argument

d2ed22f

In all cases, the passed span was already the span of the ident.

remove entirely unused cx methods

dc45d5d

Add layout_of_ prefix to all the layout-calculating methods

e1dfc38

Improves consistency, and hopefully clarifies the purpose of previously-mysteriosly named methods like `univariant`.

utilize the cx helpers where possible

fe4b0c6

Most of these cases were found by searching for uses of `DUMMY_NODE_ID`.

rename "lambda" to "closure"

063fab4

Also inline `lambda0` and `lambda1` since they're only used once and are trivial wrappers around `lambda`.

remove trivial type annotations

7698a86

move std_path to build.rs, remove unused def_site_path

fe9b2e9

It is much more similar to the methods there than to the methods in `base.rs`.

cleanup some Vecs in autodiff.rs

529a0ae

`new_inputs` and `idents` are never read anywhere, several other `Vec`s are supposed to be `ThinVec`s instead.

rust-bors Bot added the rollup A PR which is a rollup label Sep 28, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Sep 28, 2026

Rollup of 2 pull requests #163423

Closed

jhpratt mentioned this pull request Sep 28, 2026

Rollup of 2 pull requests #163424

Closed

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 28, 2026

rust-bors Bot merged commit 28b6e69 into rust-lang:main Sep 28, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Sep 28, 2026

jhpratt deleted the rollup-GBSeJEM branch September 28, 2026 07:20

Navigation Menu

Uh oh!

Rollup of 11 pull requests - #163419

Rollup of 11 pull requests#163419
rust-bors[bot] merged 46 commits into
rust-lang:mainfrom
jhpratt:rollup-GBSeJEM

jhpratt commented Sep 28, 2026

Uh oh!

jhpratt commented Sep 28, 2026

Uh oh!

rust-bors Bot commented Sep 28, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Sep 28, 2026

Uh oh!

rust-bors Bot commented Sep 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Conversation

jhpratt commented Sep 28, 2026

Uh oh!

jhpratt commented Sep 28, 2026

Uh oh!

rust-bors Bot commented Sep 28, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Sep 28, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-bors Bot commented Sep 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants