Rollup of 8 pull requests - #163695
Merged
Merged
Rollup of 8 pull requests#163695
Conversation
LLVM 24 got smarter and is able to mark some more things noundef, which showed up in some of our test checks.
When building `core` with `--cfg no_io_statics`, the compiler warns:
error: unused variable: `f`
--> .../library/core/src/io/error/os_functions.rs:9:36
|
9 | pub(super) unsafe fn set_functions(f: &'static OsFunctions) {
| ^ help: if this is intentional, prefix it with an underscore: `_f`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
Thus clean it up.
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Similar to the existing tests for other `cfg`s like `no_fp_fmt_parse`, add one for `no_io_statics`. This should prevent issues like the one in the parent commit. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
We are refactoring from a large enum where the fields of the variants contain all the reflection info to a flat enum containing only the type kind (struct/bool/array etc). While we removed the fields of Struct, Enum and Union we forgot to take out the const eval code writing into those fields. That gave an ICE. This fixes that.
…h726 add `ignore-compare-mode-next-solver` to all next-solver tests Adds `//@ ignore-compare-mode-next-solver (explicit revisions)` to all next-solver revision tests. Used an LLM to automate this and did a self-review. Can recommend only looking at `.rs` files.
…fo, r=oli-obk reflection: fix ICE when TypeId::info called on ADT We are refactoring from a large enum where the fields of the variants contain all the reflection info to a flat enum containing only the type kind (struct/bool/array etc). While we removed the fields of Struct, Enum and Union we forgot to take out the const eval code writing into those fields. That gave an ICE. This fixes that.
…ype-in-generics, r=JonathanBrouwer Improve suggestion for lifetime preceding type in generics Closes rust-lang#59325 Specifically, this fixes cases like the 2nd example in the issue, where a lifetime precedes a type in generic args: `Foo<'static T1>` and suggests either adding a reference, i.e. `Foo<&'static T1>` or a comma, i.e. `Foo<'static, T1>`. In a case like `Foo<'static mut T1>`, only `Foo<&'static mut T1>` is suggested.
…nikic tests: accept noundef in a couple more places LLVM 24 got smarter and is able to mark some more things noundef, which showed up in some of our test checks. @rustbot label: +llvm-main
…s, r=JohnTitor
core: io: clean `unused_variables` lint under `no_io_statics`
When building `core` with `--cfg no_io_statics`, the compiler warns:
error: unused variable: `f`
--> .../library/core/src/io/error/os_functions.rs:9:36
|
9 | pub(super) unsafe fn set_functions(f: &'static OsFunctions) {
| ^ help: if this is intentional, prefix it with an underscore: `_f`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
Thus clean it up.
---
If the signature is preferred to be exactly the same one as the `os_functions_atomic.rs` one, then we could `allow` it instead.
…, r=traviscross Make the tracking issue template better suited for experiments The lang team's experiment docs say to create a tracking issue, but the tracking issue template isn't well suited for features that lack an RFC. These are minor changes that should streamline the process. Thanks to @diondokter for pointing out how these could be improved. r? lang-ops
… r=RalfJung Avoid long iterator chain in all_rust_features This chain creates an absolute monster type that clutters my cachegrind diffs :) This should make it simpler. I believe we've also seen `chain` to optimize poorly, but I don't think that's a concern here. It might also compile faster, we know that deep types created with iterator chains tend to scale poorly.
…ion, r=hanna-kruppe refactor: migrate to LLVM-C's `LLVMGetOrInsertFunction` As the removed fixme already states we don't need to maintain our own wrapper anymore as `LLVMGetOrInsertFunction` is part of LLVM since version 22.
rustbot
added
A-LLVM
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 3, 2026
Rollup of 8 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Oct 3, 2026
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d6b6dc7 (parent) -> db8f076 (this PR) Test differencesShow 9 test diffsStage 1
Stage 2
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard db8f076d2619ce2585b0380dda06e8da25a40da4 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (db8f076): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.0%, secondary 3.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 1.9%, secondary -0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 489.814s -> 492.227s (0.49%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: d6b6dc7982 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ignore-compare-mode-next-solverto all next-solver tests #163645 (addignore-compare-mode-next-solverto all next-solver tests)unused_variableslint underno_io_statics#163633 (core: io: cleanunused_variableslint underno_io_statics)LLVMGetOrInsertFunction#163690 (refactor: migrate to LLVM-C'sLLVMGetOrInsertFunction)Failed merges:
r? @ghost
Create a similar rollup