Verify Mattermost TLS by default - #294
Merged
abeldantas merged 1 commit intoSep 4, 2026
Merged
Conversation
_create_driver hardcoded verify=False, so the admin password and bot tokens were sent over an unverified https connection (a MITM could capture them). Default TLS verification on, with a verify_tls opt-out for a trusted self-signed CA.
jameshoweee
requested review from
amaudruz and
christian-mcdermott
as code owners
August 25, 2026 16:20
|
All contributors have signed the CLA. ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
recheck |
1 similar comment
Contributor
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mattermost driver hardcoded
verify=False, so the admin password and bot tokens were sent over an unverified https connection (a MITM could capture them).Fix: default TLS verification on; add a
verify_tlsopt-out for a trusted self-signed internal CA.