Stop exporting metrics from the collector - #2628
Conversation
Drops the metrics pipeline, its exporter and its filter. We don't get enough out of metrics to justify keeping them. The .NET side still emits them; removing that follows in a separate PR. What made it urgent is the event quota. Honeycomb put us into dual ingest with their June 2026 time series metrics rollout, so every datapoint is also written as a billable event. That copy is 78% of everything we send (410,481 of 523,408 ingested over 7 days, across all three environments), and it is what pushed us past the 20M events/month limit and got us throttled. Around 10 December 2026 Honeycomb retires metrics-as-events for Free plans. After that, metrics no longer cost anything against the event quota, so we can turn this back on for free if we decide we want them. If we do, write the config fresh rather than reverting this commit. What is removed here is already behind Honeycomb's current docs: the x-honeycomb-dataset header is a leftover from the legacy metrics experience and is no longer used for routing. Until the .NET change lands the services keep exporting metrics the collector no longer accepts, which is harmless. The OTLP receiver only registers a signal's service if a pipeline consumes it, so gRPC (port 4317, what the services use) answers Unimplemented and HTTP answers 404. Neither is a retryable status, so a batch is dropped once per export interval rather than retried, and nothing reaches the app log because OpenTelemetry .NET reports export failures on an EventSource we don't listen to. Traces and logs are unaffected. Checked against the pinned otel/opentelemetry-collector-contrib:0.101.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe OpenTelemetry Collector configuration removes the metrics filter processor, dedicated metrics exporter, and metrics service pipeline. ChangesMetrics configuration removal
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This change removes the collector metrics pipeline while retaining trace and log telemetry paths. No current merge-blocking risk is identified. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removes the metrics pipeline, its exporter and its filter. Traces and logs are unaffected.
x-honeycomb-datasetheader is a leftover from the legacy metrics experience and is no longer used for routing.