Skip to content

Stop exporting metrics from the collector - #2628

Open
myieye wants to merge 1 commit into
developfrom
claude/otel-drop-duplicate-metrics-dataset
Open

Stop exporting metrics from the collector#2628
myieye wants to merge 1 commit into
developfrom
claude/otel-drop-duplicate-metrics-dataset

Conversation

@myieye

@myieye myieye commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Removes the metrics pipeline, its exporter and its filter. Traces and logs are unaffected.

  • We don't really need metrics. Removing them from the .NET side follows in a separate PR.
  • They were pushing us over our Honeycomb event quota. Honeycomb's June 2026 time series migration put us in dual ingest, so every datapoint is also written as a billable event — 78% of everything we send, and what got us throttled.
  • Around 10 December 2026 Honeycomb stops dual-ingesting metrics as events, so we could turn this back on for free then if we want it.
  • If we do, write the config fresh rather than reverting. What's removed here is already behind Honeycomb's current docs — the x-honeycomb-dataset header is a leftover from the legacy metrics experience and is no longer used for routing.

Drops the metrics pipeline, its exporter and its filter. We don't get enough out
of metrics to justify keeping them. The .NET side still emits them; removing that
follows in a separate PR.

What made it urgent is the event quota. Honeycomb put us into dual ingest with
their June 2026 time series metrics rollout, so every datapoint is also written as
a billable event. That copy is 78% of everything we send (410,481 of 523,408
ingested over 7 days, across all three environments), and it is what pushed us
past the 20M events/month limit and got us throttled.

Around 10 December 2026 Honeycomb retires metrics-as-events for Free plans. After
that, metrics no longer cost anything against the event quota, so we can turn this
back on for free if we decide we want them.

If we do, write the config fresh rather than reverting this commit. What is removed
here is already behind Honeycomb's current docs: the x-honeycomb-dataset header is
a leftover from the legacy metrics experience and is no longer used for routing.

Until the .NET change lands the services keep exporting metrics the collector no
longer accepts, which is harmless. The OTLP receiver only registers a signal's
service if a pipeline consumes it, so gRPC (port 4317, what the services use)
answers Unimplemented and HTTP answers 404. Neither is a retryable status, so a
batch is dropped once per export interval rather than retried, and nothing reaches
the app log because OpenTelemetry .NET reports export failures on an EventSource we
don't listen to. Traces and logs are unaffected. Checked against the pinned
otel/opentelemetry-collector-contrib:0.101.0.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 562b1585-9256-446f-9c80-254003ed7707

📥 Commits

Reviewing files that changed from the base of the PR and between 014db7b and 78078dd.

📒 Files selected for processing (1)
  • otel/collector-config.yaml
💤 Files with no reviewable changes (1)
  • otel/collector-config.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The OpenTelemetry Collector configuration removes the metrics filter processor, dedicated metrics exporter, and metrics service pipeline.

Changes

Metrics configuration removal

Layer / File(s) Summary
Remove metrics routing
otel/collector-config.yaml
The configuration removes metric filtering rules, the dedicated Honeycomb metrics exporter, and the metrics pipeline wiring.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 78078

This change removes the collector metrics pipeline while retaining trace and log telemetry paths. No current merge-blocking risk is identified.

Poem

A rabbit hops through config lines
The metrics trail now softly winds
No filter gate, no exporter cart
The pipeline rests, its work now part
Clean YAML leaves a tidy heart

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the main change: the collector will stop exporting metrics.
Description check ✅ Passed The description directly explains the removal of the metrics pipeline, exporter, and filter. It also states that traces and logs remain unaffected and provides the reason for the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/otel-drop-duplicate-metrics-dataset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant