deps(deps-dev): bump rubocop from 1.88.2 to 1.89.0 - #213
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
simonx1
added a commit
that referenced
this pull request
Aug 21, 2026
Supersedes #214, which kept the 3.2 job alive by gating the OpenAI SDK dev dependency behind a Ruby-version check and disabling gem caching on that one job. ## Problem `bundle install` fails on the Ruby 3.2 matrix job whenever Bundler has to resolve for real (i.e. whenever `setup-ruby`'s cache misses, as it does on any PR that touches a rubygems-sourced gem — #213 is the current example): ``` openai-0.77.0 requires ruby version >= 3.3.0, which is incompatible with the current version, 3.2.11 ``` #207 and #212 moved the git-sourced `openai` dev dependency to revisions where upstream raised its `required_ruby_version` to `>= 3.3.0`, while the gemspec here still declared `>= 3.2.0` and CI still tested that floor. ## Fix Drop 3.2 instead of working around it. Ruby 3.2 has been EOL since 2026-03-31, `.rubocop.yml` already sets `TargetRubyVersion: 3.3.5`, and a Gemfile/CI workaround for one dependency would have had to be maintained indefinitely. - `ruby-mcp-client.gemspec`: `required_ruby_version` is now `>= 3.3.0`. - `.github/workflows/ci.yml`: the two-entry matrix becomes a single `Test (Ruby 3.3, floor)` job, mirroring the shape of the 4.0.6 job. Gem caching stays on for both. - `README.md`: the Requirements section states the new floor. No library code changes. No `Gemfile.lock` changes. ## Breaking change This is a breaking change for anyone installing the gem on Ruby 3.2 — RubyGems will refuse the next released version there. `CHANGELOG.md` is written at release time in this repo, so the next release's **Breaking Changes** section should carry an entry for this. ## Verification - **Ruby 4.0.6:** `bundle install` leaves `Gemfile.lock` byte-identical; RuboCop clean; 1701 examples, 0 failures. - **Ruby 3.3.5 (new floor), uncached resolve in a fresh worktree:** `Gemfile.lock` byte-identical after `bundle install`, so the CI job's cached lockfile replay and a real resolve agree; RuboCop clean; 1701 examples, 0 failures. - No branch protection or rulesets reference the old `test (3.2)` / `test (3.3)` check names, so the rename is safe. Once merged, `@dependabot rebase` on #213 should turn it green. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Owner
|
@dependabot rebase |
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.88.2 to 1.89.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.88.2...v1.89.0) --- updated-dependencies: - dependency-name: rubocop dependency-version: 1.89.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/bundler/rubocop-1.89.0
branch
from
August 21, 2026 10:41
aa25f38 to
f320195
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.88.2 to 1.89.0.
Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
65854e6Cut 1.89f5dbd74Update Changelog2f96cd7Add new Lint/NameTypo cop9a91e2bPromote the resolved-ancestry guard to ProjectIndexHelpe917b65Merge pull request #15522 from joklek-vinted/fix/mise-toml-with-single-quotes619e3d2Fix Ruby version detection from mise.toml with single quotes7999d1a[Fix #15501] ImproveStyle/RedundantLineContinuationperformance on adjacen...63d9361Advertise executeCommandProvider in the language server893a02fCache the LSP project index across requests3b9755fMerge pull request #15516 from koic/fix_a_flaky_line_length_spec_timeout_on_j...