Section the cut list for trapped antennas; label vertical radiator vs radials - #11
Merged
Conversation
… radials
Two more build-sheet problems on the multiband designs, both from grouping the
deck's wires by length:
1. Trapped dipole / vertical (the wizard outputs) showed the radiator as one
continuous wire — the traps are NEC loads, not cuts — so the builder got
trap winding specs but no idea where to cut or place them.
2. A vertical's cut list conflated the radiator with same-length radials into a
single nonsensical line (e.g. "qty 33"), and never labelled which was which.
Now the cut list is built from the model for these:
* Trapped/loaded centre-fed dipole & inverted-V, and any vertical/inverted-L:
the radiator is split into the wire sections between the feedpoint, each
trap/coil, and the tip ("Feedpoint -> T1", "T1 -> T2", "T2 -> tip"), with
section labels matching the winding section. A centre-fed dipole is a
symmetric pair (quantity 2); a base-fed vertical is one arm.
* Vertical/inverted-L radials are their own labelled entries ("Ground
radials" / "Elevated radials", quantity = count) at their true length,
never merged with the radiator.
build_sheet now composes the cut list via _compose_cut_list (fan dipole /
vertical / loaded-dipole / generic), and the model-driven antennas take their
wire total from that cut list. Every other antenna is unchanged.
Tests: trapped-dipole sectioning (qty 2 per leg), trapped-vertical sections +
separate radials (no qty-33 conflation), plain-vertical radiator/radial
labels. Suite 516 -> 519.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Following the fan-dipole build-sheet fix (#10), I checked the other multiband antennas. Two more problems, both from the cut list grouping the deck's wires purely by length:
Fix — model-driven cut list for these antennas
Feedpoint → T1,T1 → T2,T2 → tip— with labels matching the winding/reactance sections. A centre-fed dipole is a symmetric pair (quantity 2); a base-fed vertical is a single arm.Ground radials/Elevated radials, quantity = count, at true length), never merged with the radiator.build_sheetnow composes the cut list via_compose_cut_list(fan dipole / vertical / loaded-dipole / generic), and the model-driven antennas take their wire total from that cut list. Every other antenna is unchanged (verified — existing build-sheet/coil/vertical/sketch tests pass untouched).Before → after
Tests
tests/test_buildsheet.py(+3): trapped-dipole sectioning (qty 2 per leg, no "Antenna wire"), trapped-vertical sections + separate radials (no qty-33 conflation), plain-vertical radiator/radial labels. Suite 516 → 519, green locally.🤖 Generated with Claude Code