fix: render runtime world state (exit door, traps, dynamic solids) - #155
Merged
Conversation
Introduces RenderWorld interface bundling runtime world state (tiles, exit, hazards, dynamic solids) and threads it through the render pipeline so the renderer sees trap/mechanic modifications instead of static LevelData. - CP1: Define RenderWorld in model.ts (cols, rows, tiles, exit, hazards, dynamicSolids) - CP2: Refactor buildTileLayer to accept RenderWorld; render exit door (exit.door), hazards (hazard.spikes), dynamic solid fill-rects; remove Tile.Hazard branch (physics grid has no Hazard entries) - CP3: Update buildRenderModel to accept RenderWorld - CP4: Update RenderContext + renderFrame to use RenderWorld - CP5: renderGame builds RenderWorld from scene.runtime.world + mechanicsRuntime.publishedSolids/Hazards - CP6: Update model.test.ts and renderer.test.ts with makeWorld helper and new tests for exit door, hazards, dynamic solids, culling - CP7: All checks pass (test, lint, typecheck, build) Closes #154
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sv-tmueller
marked this pull request as ready for review
August 16, 2026 20:31
Math.ceil dropped partially-visible hazard cells at the left/top viewport edge, causing moving hazards to flicker when crossing the screen boundary. Changed to Math.floor so partially-visible cells remain drawn. Found by tester on PR #155.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154