fix(pi): preserve tool result outcomes - #53
Merged
Conversation
drewstone
marked this pull request as ready for review
July 30, 2026 05:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UNSETand retain unmatched results as explicitly marked root-owned tool spansRoot cause
Pi stores calls inside assistant message content, but stores their completions as separate
role: "toolResult"messages. The adapter only handled result blocks nested inside message content, so message-level results were treated as model messages and their output, status, and timing were lost.Impact
Pi traces now represent successful, failed, unfinished, out-of-order, and orphaned tool outcomes without inventing model calls or dropping result evidence.
Validation
pnpm vitest run tests/adapters.test.ts -t 'pi tool results'— 4 passedpnpm typecheck— passedpnpm test— 371 passedpnpm build— passedpnpm check:package— passedgit merge-tree --write-tree origin/main HEAD— clean