Skip to content

ORCA-903: regenerate @team-plain/graphql after isSuccess removal - #63

Merged
presmihaylov merged 3 commits into
mainfrom
orca-903-regen-graphql-isSuccess-removed
Sep 7, 2026
Merged

ORCA-903: regenerate @team-plain/graphql after isSuccess removal#63
presmihaylov merged 3 commits into
mainfrom
orca-903-regen-graphql-isSuccess-removed

Conversation

@presmihaylov

@presmihaylov presmihaylov commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Closes ORCA-903.

Why. ORCA-891 (team-plain/services#10202) removed the deprecated isSuccess field from the API. That deploy is live in prod-uk, so the bundled schema was stale.

How.

  • Pure regen output, no hand edits.
  • Changeset is minor, per Pres: BYOA is not live in prod for customers yet.
  • The break already shipped. 3.0.0 stopped selecting this field, so it left the generated result types then, as a major. _generated_documents.graphql holds 0 occurrences, so no document selects it and no result type changes here.
  • What is left is the bundled schema copy and the field on the exported ThreadDiscussionToolCallEntryPayload type. That type is public, so code naming ['isSuccess'] stops compiling.
  • Control: the same codegen against the pre-deploy schema gave an empty diff, so this diff is attributable to ORCA-891 alone.

What. Two generated files, 12 deletions, 0 insertions.

type ThreadDiscussionToolCallEntryPayload {
  status: DiscussionToolCallStatus!   # PENDING | SUCCESS | ERROR, read this instead
- isSuccess: Boolean! @deprecated(reason: "Use status, which separates PENDING from ERROR.")
}

Note

Low Risk
Generated schema sync only; no operation selections change. Risk is limited to TypeScript consumers that still index the removed public type field.

Overview
Regenerates @team-plain/graphql against the live API so the bundled schema.graphql and _generated_documents.ts no longer define isSuccess on ThreadDiscussionToolCallEntryPayload.

Runtime/query result shapes are unchanged here: 3.0.0 already stopped selecting that field, so generated operation types did not include it. This PR only removes the last schema/type traces. Minor bump per changeset.

Compile-time break for direct type access: code referencing ThreadDiscussionToolCallEntryPayload['isSuccess'] fails with TS2339. Use status (PENDING | SUCCESS | ERROR) instead—not a naive status === 'SUCCESS' mapping from the old boolean, because false meant both pending and failed.

Reviewed by Cursor Bugbot for commit 6ac59d6. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a8271ce. Configure here.

@@ -0,0 +1,9 @@
---
"@team-plain/graphql": minor

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking field drop marked minor

Medium Severity

isSuccess is removed from the public ThreadDiscussionToolCallEntryPayload type while the changeset is minor. Callers that name that property fail with TS2339, and a ^3.0.0 range would take the change without an explicit major bump.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by learned rule: Generated docs drop deprecated fields

Reviewed by Cursor Bugbot for commit a8271ce. Configure here.

@presmihaylov
presmihaylov merged commit 824fe05 into main Sep 7, 2026
4 checks passed
@presmihaylov
presmihaylov deleted the orca-903-regen-graphql-isSuccess-removed branch September 7, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants