ORCA-903: regenerate @team-plain/graphql after isSuccess removal - #63
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a8271ce. Configure here.
| @@ -0,0 +1,9 @@ | |||
| --- | |||
| "@team-plain/graphql": minor | |||
There was a problem hiding this comment.
Breaking field drop marked minor
Medium Severity
isSuccess is removed from the public ThreadDiscussionToolCallEntryPayload type while the changeset is minor. Callers that name that property fail with TS2339, and a ^3.0.0 range would take the change without an explicit major bump.
Additional Locations (1)
Triggered by learned rule: Generated docs drop deprecated fields
Reviewed by Cursor Bugbot for commit a8271ce. Configure here.


Closes ORCA-903.
Why. ORCA-891 (team-plain/services#10202) removed the deprecated
isSuccessfield from the API. That deploy is live in prod-uk, so the bundled schema was stale.How.
minor, per Pres: BYOA is not live in prod for customers yet._generated_documents.graphqlholds 0 occurrences, so no document selects it and no result type changes here.ThreadDiscussionToolCallEntryPayloadtype. That type is public, so code naming['isSuccess']stops compiling.What. Two generated files, 12 deletions, 0 insertions.
Note
Low Risk
Generated schema sync only; no operation selections change. Risk is limited to TypeScript consumers that still index the removed public type field.
Overview
Regenerates
@team-plain/graphqlagainst the live API so the bundledschema.graphqland_generated_documents.tsno longer defineisSuccessonThreadDiscussionToolCallEntryPayload.Runtime/query result shapes are unchanged here: 3.0.0 already stopped selecting that field, so generated operation types did not include it. This PR only removes the last schema/type traces. Minor bump per changeset.
Compile-time break for direct type access: code referencing
ThreadDiscussionToolCallEntryPayload['isSuccess']fails with TS2339. Usestatus(PENDING|SUCCESS|ERROR) instead—not a naivestatus === 'SUCCESS'mapping from the old boolean, becausefalsemeant both pending and failed.Reviewed by Cursor Bugbot for commit 6ac59d6. Bugbot is set up for automated code reviews on this repo. Configure here.