-
Notifications
You must be signed in to change notification settings - Fork 1
ORCA-903: regenerate @team-plain/graphql after isSuccess removal #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "@team-plain/graphql": minor | ||
| --- | ||
|
|
||
| Regenerate against the current API schema. The API removed the deprecated `isSuccess` field from `ThreadDiscussionToolCallEntryPayload`, so it is gone from the bundled schema and from the exported type of the same name. | ||
|
|
||
| **Nothing a caller reads off a response changes, and this is not a second break.** 3.0.0 already stopped selecting `isSuccess`, which removed it from the generated result types and shipped as a major. What is left to remove here is the last two traces: the bundled schema copy and the field on the exported `ThreadDiscussionToolCallEntryPayload` type. No document selected it, so no result type changes. | ||
|
|
||
| That exported type is still public API, so code naming `ThreadDiscussionToolCallEntryPayload['isSuccess']` stops compiling with TS2339. Read `status` instead, a `DiscussionToolCallStatus` of `PENDING`, `SUCCESS` or `ERROR`. Do not translate the old boolean as `status === 'SUCCESS'` and stop: `false` covered a call that was still running as well as one that failed, so code treating every `false` as a failure was already mislabelling pending calls. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking field drop marked minor
Medium Severity
isSuccessis removed from the publicThreadDiscussionToolCallEntryPayloadtype while the changeset isminor. Callers that name that property fail with TS2339, and a^3.0.0range would take the change without an explicit major bump.Additional Locations (1)
packages/graphql/src/_generated_documents.ts#L14599-L14609Triggered by learned rule: Generated docs drop deprecated fields
Reviewed by Cursor Bugbot for commit a8271ce. Configure here.